Support official Chrome builders.

Support official Chrome builders.

These builders supply the test_spec as a property in the bot_config.
Allow this to override the reading of the test_spec.

(Follow-on to https://codereview.chromium.org/1565113003 .)

BUG=542370
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298225

[Ken Russell (switch to Gerrit), 2016-01-12 03:45:38]

kbr@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, sergeyberezin@chromium.org, sergiyb@chromium.org

[Ken Russell (switch to Gerrit), 2016-01-12 03:45:38]

Please review.

This is needed for https://chromereviews.googleplex.com/337217013/ ; please see
the other CL for details.

[Sergiy Byelozyorov, 2016-01-12 09:29:56]

lgtm

[Sergiy Byelozyorov, 2016-01-12 09:31:04]

https://codereview.chromium.org/1577983006/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/1577983006/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:371:
'ChromePracticeFullTester': {
Why was this added? Is this a real config or just used for testing?

[Sergiy Byelozyorov, 2016-01-12 09:41:34]

lgtm w/ comments

https://codereview.chromium.org/1577983006/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/1577983006/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:393: 'test_spec': {
nit: keep } on the same line, i.e. 'test_spec': {}
it's just my preference, feel free to keep it as is if you think otherwise

[Paweł Hajdan Jr., 2016-01-12 09:55:05]

LGTM

[Ken Russell (switch to Gerrit), 2016-01-12 18:29:07]

https://codereview.chromium.org/1577983006/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/1577983006/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:371:
'ChromePracticeFullTester': {
On 2016/01/12 09:31:04, Sergiy Byelozyorov wrote:
> Why was this added? Is this a real config or just used for testing?

It's a testing config used to get to 100% code coverage in the standalone build/
workspace. Otherwise it's only configs in build_internal that cover the new code
path.

https://codereview.chromium.org/1577983006/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:393: 'test_spec': {
On 2016/01/12 09:41:34, Sergiy Byelozyorov wrote:
> nit: keep } on the same line, i.e. 'test_spec': {}
> it's just my preference, feel free to keep it as is if you think otherwise

I'm going to leave this as is. It's the same way in the build_internal
workspace.

[Ken Russell (switch to Gerrit), 2016-01-12 18:29:12]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-01-12 18:29:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1577983006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1577983006/1

[commit-bot: I haz the power, 2016-01-12 18:31:59]

Description was changed from

==========
Support official Chrome builders.

These builders supply the test_spec as a property in the bot_config.
Allow this to override the reading of the test_spec.

(Follow-on to https://codereview.chromium.org/1565113003 .)

BUG=542370
==========

to

==========
Support official Chrome builders.

These builders supply the test_spec as a property in the bot_config.
Allow this to override the reading of the test_spec.

(Follow-on to https://codereview.chromium.org/1565113003 .)

BUG=542370

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298225
==========

[commit-bot: I haz the power, 2016-01-12 18:32:00]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298225