Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 1565113003: Add concept of bot config and test spec database (BotConfigAndTestDB). (Closed)

Created:
4 years, 11 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add concept of bot config and test spec database (BotConfigAndTestDB). This class abstracts the (master_dict, test_spec) pair that is returned from api.chromium_tests.prepare_checkout. It will allow the database to support multiple waterfalls (masternames) while avoiding changing most callers' code. BUG=542370 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298207

Patch Set 1 #

Total comments: 20

Patch Set 2 : Addressed review feedback. #

Patch Set 3 : Rebased. (Probably unnecessary.) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -93 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/api.py View 4 chunks +12 lines, -11 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/example.py View 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/api.py View 17 chunks +55 lines, -37 lines 0 comments Download
A scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py View 1 1 chunk +51 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/perf_try/api.py View 8 chunks +14 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.py View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.py View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.py View 1 chunk +4 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 1 2 5 chunks +8 lines, -9 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.py View 3 chunks +3 lines, -4 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Ken Russell (switch to Gerrit)
All: please review. For context: after an offline discussion between sergeyberezin, iannucci, luqui and I ...
4 years, 11 months ago (2016-01-08 07:33:24 UTC) #2
Sergiy Byelozyorov
LGTM - I see no problem with this refactoring. Changes that are needed to make ...
4 years, 11 months ago (2016-01-08 10:35:58 UTC) #3
Paweł Hajdan Jr.
LGTM w/nit https://codereview.chromium.org/1565113003/diff/1/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py File scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py (right): https://codereview.chromium.org/1565113003/diff/1/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py#newcode18 scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py:18: pass nit: This line shouldn't be needed ...
4 years, 11 months ago (2016-01-08 16:00:42 UTC) #4
Sergey Berezin
LGTM + a few nits. Thanks! https://codereview.chromium.org/1565113003/diff/1/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py File scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py (right): https://codereview.chromium.org/1565113003/diff/1/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py#newcode5 scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py:5: import collections Not ...
4 years, 11 months ago (2016-01-08 18:54:14 UTC) #5
Ken Russell (switch to Gerrit)
FYI, I'm going to wait to CQ this until I've reimplemented https://codereview.chromium.org/1554383003/ on top of ...
4 years, 11 months ago (2016-01-08 23:02:45 UTC) #6
Sergey Berezin
https://codereview.chromium.org/1565113003/diff/1/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py File scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py (right): https://codereview.chromium.org/1565113003/diff/1/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py#newcode7 scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py:7: class BotConfigAndTestDB(object): On 2016/01/08 23:02:44, Ken Russell wrote: > ...
4 years, 11 months ago (2016-01-08 23:31:59 UTC) #7
Ken Russell (switch to Gerrit)
Since it sounds like the dependent CL https://codereview.chromium.org/1574433004 will make progress, I'm going to CQ ...
4 years, 11 months ago (2016-01-11 22:03:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565113003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565113003/40001
4 years, 11 months ago (2016-01-11 22:03:31 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298207
4 years, 11 months ago (2016-01-11 22:06:52 UTC) #13
Ken Russell (switch to Gerrit)
4 years, 11 months ago (2016-01-12 03:47:12 UTC) #14
Message was sent while issue was closed.
On 2016/01/11 22:06:52, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=298207

Note: luqui pointed out that this CL broke the internal recipes. I've prepared
two CLs, one in tools/build and one in build_internal, fixing the breakage. My
preference would be to land those two CLs rather than revert this one, but if
you feel it's necessary, please revert this. Thanks.

Powered by Google App Engine
This is Rietveld 408576698