Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1577983004: Avoid VS 2015 truncation warning (Closed)

Created:
4 years, 11 months ago by brucedawson
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@vs2015_package
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid VS 2015 truncation warning battor_agent.cc(78): warning C4267: conversion from size_t to uint8_t This was missed by the VS 2015 fyi bots because battor_agent is not one of their targets. size_t is a better choice than uint8_t anyway. BUG=440500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/battor_agent/battor_agent.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
brucedawson
Soon we'll be on VS 2015 and these won't be a problem. This depends on ...
4 years, 11 months ago (2016-01-12 00:56:36 UTC) #2
Primiano Tucci (use gerrit)
LGTM
4 years, 11 months ago (2016-01-12 10:09:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577983004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577983004/1
4 years, 11 months ago (2016-01-12 18:16:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/141872) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 11 months ago (2016-01-12 18:21:31 UTC) #8
brucedawson
4 years, 11 months ago (2016-01-12 18:45:39 UTC) #9
crrev.com/1579753002 fixed this independently, which is why there were merge
conflicts. I'm going to close this CL.

Powered by Google App Engine
This is Rietveld 408576698