Change VS 2015 Update 1 package to VM version

Change VS 2015 Update 1 package to VM version

The original VS 2015 Update 1 toolchain package was created on a
development machine and was not reproducible. This package was
created on a clean VM in hopes of making it reproducible. The
steps to create it are:

Install Windows 7 Professional, 64-bit
Install VS 2015 Professional Update 1. Select custom install and these
minimum options:
- Visual C++ (which selects three sub-categories including MFC)
- Universal Windows App Development Tools
  - Tools (1.2) and Windows 10 SDK (10.0.10586)

Then download the Windows 10 SDK. The version must match the one
installed with VS 2015 Update 1 or else there will be warnings about
the need to uninstall the previous version. Select "Debugging Tools
for Windows" in addition to the defaults (Windows App Certification Kit,
Windows Software Development Kit). Note, however, that this just
downloads the installers. A message will suggest that running setup.exe
will install the requested components but actually you have to go into
the Downloads\Windows Kits\10\StandaloneSDK\Installers directory to
run the x86 and x64 debugger installers.

Then install depot_tools and run:

> python depot_tools\win_toolchain\package_from_installed.py 2015

The package is uploaded with this syntax (replace hash.zip):

> python depot_tools\third_party\gsutil\gsutil cp hash.zip
gs://chrome-wintoolchain/hash.zip

This process arguably packages up more files than are needed. The
sys32\api_ms-* files can't actually be used in this form - the Universal
Windows 10 C Runtime needs to be installed. These files are also
different on difference OSes, so packaging them doesn't really make
sense. Also the VC\lib\onecore and VC\redist\onecore files are large and
appear to be unneeded. But, removing these is not important.

BUG=440500
Committed: https://crrev.com/94c4e7106c3783cf35f5fe00561ce445382fc0ae
Cr-Commit-Position: refs/heads/master@{#368760}

[brucedawson, 2016-01-11 23:30:41]

Description was changed from

==========
Change VS 2015 Update 1 package to VM version

The original VS 2015 Update 1 toolchain package was created on a
development machine and was not reproducible. This package was
created on a clean VM in hopes of making it reproducible. The
steps to create it are:

Install Windows 7 Professional, 64-bit
Install VS 2015 Professional Update 1. Select custom install and these
minimum options:
- Visual C++
- Universal Windows App Development Tools
  - Tools (1.2) and Windows 10 SDK (10.0.10586)

Then download the Windows 10 SDK. The version must match the one
installed with VS 2015 Update 1 or else there will be warnings about
the need to uninstall the previous version. Select "Debugging Tools
for Windows" in addition to the defaults (Windows App Certification Kit,
Windows Software Development Kit). Note, however, that this just
downloads the installers. A message will suggest that running setup.exe
will install the requested components but actually you have to go into
the Downloads\Windows Kits\10\StandaloneSDK\Installers directory to
run the x86 and x64 debugger installers.

Then install depot_tools and run:

python depot_tools\win_toolchain\package_from_installed.py 2015

This process arguably packages up more files than are needed. The
sys32\api_ms-* files can't actually be used in this form - the Universal
Windows 10 C Runtime needs to be installed. Also the VC\lib\onecore and
VC\redist\onecore files are large and appear to be unneeded. But,
removing these is not important.

BUG=440500
==========

to

==========
Change VS 2015 Update 1 package to VM version

The original VS 2015 Update 1 toolchain package was created on a
development machine and was not reproducible. This package was
created on a clean VM in hopes of making it reproducible. The
steps to create it are:

Install Windows 7 Professional, 64-bit
Install VS 2015 Professional Update 1. Select custom install and these
minimum options:
- Visual C++
- Universal Windows App Development Tools
  - Tools (1.2) and Windows 10 SDK (10.0.10586)

Then download the Windows 10 SDK. The version must match the one
installed with VS 2015 Update 1 or else there will be warnings about
the need to uninstall the previous version. Select "Debugging Tools
for Windows" in addition to the defaults (Windows App Certification Kit,
Windows Software Development Kit). Note, however, that this just
downloads the installers. A message will suggest that running setup.exe
will install the requested components but actually you have to go into
the Downloads\Windows Kits\10\StandaloneSDK\Installers directory to
run the x86 and x64 debugger installers.

Then install depot_tools and run:

python depot_tools\win_toolchain\package_from_installed.py 2015

This process arguably packages up more files than are needed. The
sys32\api_ms-* files can't actually be used in this form - the Universal
Windows 10 C Runtime needs to be installed. These files are also
different on difference OSes, so packaging them doesn't really make
sense. Also the VC\lib\onecore and VC\redist\onecore files are large and
appear to be unneeded. But, removing these is not important.

BUG=440500
==========

[brucedawson, 2016-01-11 23:34:23]

brucedawson@chromium.org changed reviewers:
+ scottmg@chromium.org

[brucedawson, 2016-01-11 23:34:23]

I'm currently doing a VS 2015 build with this package, which is working. I'm not
sure what other testing is needed.

I could strip ~220 MB of probably unneeded data from this package, but it
doesn't seem worth it.

I don't know if this package is actually reproducible, but I think it's as
reproducible as possible.

This should be the final Update 1 package.

[scottmg, 2016-01-11 23:36:56]

On 2016/01/11 23:34:23, brucedawson wrote:
> I'm currently doing a VS 2015 build with this package, which is working. I'm
not
> sure what other testing is needed.
> 
> I could strip ~220 MB of probably unneeded data from this package, but it
> doesn't seem worth it.
> 
> I don't know if this package is actually reproducible, but I think it's as
> reproducible as possible.
> 
> This should be the final Update 1 package.

OK, lgtm. I think if we're not going to use sys32\api-blah it'd be better to
remove them to be less confusing. But if it's otherwise working, it's OK to
leave them unless you're repacking for some other reason again.

[scottmg, 2016-01-11 23:37:01]

https://codereview.chromium.org/1576203002/diff/20001/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/1576203002/diff/20001/build/vs_toolchain.py#n...
build/vs_toolchain.py:1: #!/usr/bin/env python
(description comment)

Is there still an option for MFC/ATL that you did/didn't have to toggle?

[brucedawson, 2016-01-12 00:14:01]

Description was changed from

==========
Change VS 2015 Update 1 package to VM version

The original VS 2015 Update 1 toolchain package was created on a
development machine and was not reproducible. This package was
created on a clean VM in hopes of making it reproducible. The
steps to create it are:

Install Windows 7 Professional, 64-bit
Install VS 2015 Professional Update 1. Select custom install and these
minimum options:
- Visual C++
- Universal Windows App Development Tools
  - Tools (1.2) and Windows 10 SDK (10.0.10586)

Then download the Windows 10 SDK. The version must match the one
installed with VS 2015 Update 1 or else there will be warnings about
the need to uninstall the previous version. Select "Debugging Tools
for Windows" in addition to the defaults (Windows App Certification Kit,
Windows Software Development Kit). Note, however, that this just
downloads the installers. A message will suggest that running setup.exe
will install the requested components but actually you have to go into
the Downloads\Windows Kits\10\StandaloneSDK\Installers directory to
run the x86 and x64 debugger installers.

Then install depot_tools and run:

python depot_tools\win_toolchain\package_from_installed.py 2015

This process arguably packages up more files than are needed. The
sys32\api_ms-* files can't actually be used in this form - the Universal
Windows 10 C Runtime needs to be installed. These files are also
different on difference OSes, so packaging them doesn't really make
sense. Also the VC\lib\onecore and VC\redist\onecore files are large and
appear to be unneeded. But, removing these is not important.

BUG=440500
==========

to

==========
Change VS 2015 Update 1 package to VM version

The original VS 2015 Update 1 toolchain package was created on a
development machine and was not reproducible. This package was
created on a clean VM in hopes of making it reproducible. The
steps to create it are:

Install Windows 7 Professional, 64-bit
Install VS 2015 Professional Update 1. Select custom install and these
minimum options:
- Visual C++ (which selects three sub-categories including MFC)
- Universal Windows App Development Tools
  - Tools (1.2) and Windows 10 SDK (10.0.10586)

Then download the Windows 10 SDK. The version must match the one
installed with VS 2015 Update 1 or else there will be warnings about
the need to uninstall the previous version. Select "Debugging Tools
for Windows" in addition to the defaults (Windows App Certification Kit,
Windows Software Development Kit). Note, however, that this just
downloads the installers. A message will suggest that running setup.exe
will install the requested components but actually you have to go into
the Downloads\Windows Kits\10\StandaloneSDK\Installers directory to
run the x86 and x64 debugger installers.

Then install depot_tools and run:

python depot_tools\win_toolchain\package_from_installed.py 2015

This process arguably packages up more files than are needed. The
sys32\api_ms-* files can't actually be used in this form - the Universal
Windows 10 C Runtime needs to be installed. These files are also
different on difference OSes, so packaging them doesn't really make
sense. Also the VC\lib\onecore and VC\redist\onecore files are large and
appear to be unneeded. But, removing these is not important.

BUG=440500
==========

[brucedawson, 2016-01-12 00:15:18]

On 2016/01/11 23:37:01, scottmg wrote:
> https://codereview.chromium.org/1576203002/diff/20001/build/vs_toolchain.py
> File build/vs_toolchain.py (right):
> 
>
https://codereview.chromium.org/1576203002/diff/20001/build/vs_toolchain.py#n...
> build/vs_toolchain.py:1: #!/usr/bin/env python
> (description comment)
> 
> Is there still an option for MFC/ATL that you did/didn't have to toggle?

There is still an MFC option. It defaults to being checked when you check
VisualC++. I changed the description to clarify that.

I could repackage with the sys32 files removed but it didn't seem worth it. But,
also not a big deal, unless it breaks some downstream scripts.

[brucedawson, 2016-01-12 00:17:48]

Description was changed from

==========
Change VS 2015 Update 1 package to VM version

The original VS 2015 Update 1 toolchain package was created on a
development machine and was not reproducible. This package was
created on a clean VM in hopes of making it reproducible. The
steps to create it are:

Install Windows 7 Professional, 64-bit
Install VS 2015 Professional Update 1. Select custom install and these
minimum options:
- Visual C++ (which selects three sub-categories including MFC)
- Universal Windows App Development Tools
  - Tools (1.2) and Windows 10 SDK (10.0.10586)

Then download the Windows 10 SDK. The version must match the one
installed with VS 2015 Update 1 or else there will be warnings about
the need to uninstall the previous version. Select "Debugging Tools
for Windows" in addition to the defaults (Windows App Certification Kit,
Windows Software Development Kit). Note, however, that this just
downloads the installers. A message will suggest that running setup.exe
will install the requested components but actually you have to go into
the Downloads\Windows Kits\10\StandaloneSDK\Installers directory to
run the x86 and x64 debugger installers.

Then install depot_tools and run:

python depot_tools\win_toolchain\package_from_installed.py 2015

This process arguably packages up more files than are needed. The
sys32\api_ms-* files can't actually be used in this form - the Universal
Windows 10 C Runtime needs to be installed. These files are also
different on difference OSes, so packaging them doesn't really make
sense. Also the VC\lib\onecore and VC\redist\onecore files are large and
appear to be unneeded. But, removing these is not important.

BUG=440500
==========

to

==========
Change VS 2015 Update 1 package to VM version

The original VS 2015 Update 1 toolchain package was created on a
development machine and was not reproducible. This package was
created on a clean VM in hopes of making it reproducible. The
steps to create it are:

Install Windows 7 Professional, 64-bit
Install VS 2015 Professional Update 1. Select custom install and these
minimum options:
- Visual C++ (which selects three sub-categories including MFC)
- Universal Windows App Development Tools
  - Tools (1.2) and Windows 10 SDK (10.0.10586)

Then download the Windows 10 SDK. The version must match the one
installed with VS 2015 Update 1 or else there will be warnings about
the need to uninstall the previous version. Select "Debugging Tools
for Windows" in addition to the defaults (Windows App Certification Kit,
Windows Software Development Kit). Note, however, that this just
downloads the installers. A message will suggest that running setup.exe
will install the requested components but actually you have to go into
the Downloads\Windows Kits\10\StandaloneSDK\Installers directory to
run the x86 and x64 debugger installers.

Then install depot_tools and run:

> python depot_tools\win_toolchain\package_from_installed.py 2015

The package is uploaded with this syntax (replace hash.zip):

> python depot_tools\third_party\gsutil\gsutil cp hash.zip
gs://chrome-wintoolchain/hash.zip

This process arguably packages up more files than are needed. The
sys32\api_ms-* files can't actually be used in this form - the Universal
Windows 10 C Runtime needs to be installed. These files are also
different on difference OSes, so packaging them doesn't really make
sense. Also the VC\lib\onecore and VC\redist\onecore files are large and
appear to be unneeded. But, removing these is not important.

BUG=440500
==========

[brucedawson, 2016-01-12 00:55:04]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-01-12 00:56:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576203002/20001

[commit-bot: I haz the power, 2016-01-12 01:30:52]

Description was changed from

==========
Change VS 2015 Update 1 package to VM version

The original VS 2015 Update 1 toolchain package was created on a
development machine and was not reproducible. This package was
created on a clean VM in hopes of making it reproducible. The
steps to create it are:

Install Windows 7 Professional, 64-bit
Install VS 2015 Professional Update 1. Select custom install and these
minimum options:
- Visual C++ (which selects three sub-categories including MFC)
- Universal Windows App Development Tools
  - Tools (1.2) and Windows 10 SDK (10.0.10586)

Then download the Windows 10 SDK. The version must match the one
installed with VS 2015 Update 1 or else there will be warnings about
the need to uninstall the previous version. Select "Debugging Tools
for Windows" in addition to the defaults (Windows App Certification Kit,
Windows Software Development Kit). Note, however, that this just
downloads the installers. A message will suggest that running setup.exe
will install the requested components but actually you have to go into
the Downloads\Windows Kits\10\StandaloneSDK\Installers directory to
run the x86 and x64 debugger installers.

Then install depot_tools and run:

> python depot_tools\win_toolchain\package_from_installed.py 2015

The package is uploaded with this syntax (replace hash.zip):

> python depot_tools\third_party\gsutil\gsutil cp hash.zip
gs://chrome-wintoolchain/hash.zip

This process arguably packages up more files than are needed. The
sys32\api_ms-* files can't actually be used in this form - the Universal
Windows 10 C Runtime needs to be installed. These files are also
different on difference OSes, so packaging them doesn't really make
sense. Also the VC\lib\onecore and VC\redist\onecore files are large and
appear to be unneeded. But, removing these is not important.

BUG=440500
==========

to

==========
Change VS 2015 Update 1 package to VM version

The original VS 2015 Update 1 toolchain package was created on a
development machine and was not reproducible. This package was
created on a clean VM in hopes of making it reproducible. The
steps to create it are:

Install Windows 7 Professional, 64-bit
Install VS 2015 Professional Update 1. Select custom install and these
minimum options:
- Visual C++ (which selects three sub-categories including MFC)
- Universal Windows App Development Tools
  - Tools (1.2) and Windows 10 SDK (10.0.10586)

Then download the Windows 10 SDK. The version must match the one
installed with VS 2015 Update 1 or else there will be warnings about
the need to uninstall the previous version. Select "Debugging Tools
for Windows" in addition to the defaults (Windows App Certification Kit,
Windows Software Development Kit). Note, however, that this just
downloads the installers. A message will suggest that running setup.exe
will install the requested components but actually you have to go into
the Downloads\Windows Kits\10\StandaloneSDK\Installers directory to
run the x86 and x64 debugger installers.

Then install depot_tools and run:

> python depot_tools\win_toolchain\package_from_installed.py 2015

The package is uploaded with this syntax (replace hash.zip):

> python depot_tools\third_party\gsutil\gsutil cp hash.zip
gs://chrome-wintoolchain/hash.zip

This process arguably packages up more files than are needed. The
sys32\api_ms-* files can't actually be used in this form - the Universal
Windows 10 C Runtime needs to be installed. These files are also
different on difference OSes, so packaging them doesn't really make
sense. Also the VC\lib\onecore and VC\redist\onecore files are large and
appear to be unneeded. But, removing these is not important.

BUG=440500
==========

[commit-bot: I haz the power, 2016-01-12 01:30:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-12 01:32:35]

Description was changed from

==========
Change VS 2015 Update 1 package to VM version

The original VS 2015 Update 1 toolchain package was created on a
development machine and was not reproducible. This package was
created on a clean VM in hopes of making it reproducible. The
steps to create it are:

Install Windows 7 Professional, 64-bit
Install VS 2015 Professional Update 1. Select custom install and these
minimum options:
- Visual C++ (which selects three sub-categories including MFC)
- Universal Windows App Development Tools
  - Tools (1.2) and Windows 10 SDK (10.0.10586)

Then download the Windows 10 SDK. The version must match the one
installed with VS 2015 Update 1 or else there will be warnings about
the need to uninstall the previous version. Select "Debugging Tools
for Windows" in addition to the defaults (Windows App Certification Kit,
Windows Software Development Kit). Note, however, that this just
downloads the installers. A message will suggest that running setup.exe
will install the requested components but actually you have to go into
the Downloads\Windows Kits\10\StandaloneSDK\Installers directory to
run the x86 and x64 debugger installers.

Then install depot_tools and run:

> python depot_tools\win_toolchain\package_from_installed.py 2015

The package is uploaded with this syntax (replace hash.zip):

> python depot_tools\third_party\gsutil\gsutil cp hash.zip
gs://chrome-wintoolchain/hash.zip

This process arguably packages up more files than are needed. The
sys32\api_ms-* files can't actually be used in this form - the Universal
Windows 10 C Runtime needs to be installed. These files are also
different on difference OSes, so packaging them doesn't really make
sense. Also the VC\lib\onecore and VC\redist\onecore files are large and
appear to be unneeded. But, removing these is not important.

BUG=440500
==========

to

==========
Change VS 2015 Update 1 package to VM version

The original VS 2015 Update 1 toolchain package was created on a
development machine and was not reproducible. This package was
created on a clean VM in hopes of making it reproducible. The
steps to create it are:

Install Windows 7 Professional, 64-bit
Install VS 2015 Professional Update 1. Select custom install and these
minimum options:
- Visual C++ (which selects three sub-categories including MFC)
- Universal Windows App Development Tools
  - Tools (1.2) and Windows 10 SDK (10.0.10586)

Then download the Windows 10 SDK. The version must match the one
installed with VS 2015 Update 1 or else there will be warnings about
the need to uninstall the previous version. Select "Debugging Tools
for Windows" in addition to the defaults (Windows App Certification Kit,
Windows Software Development Kit). Note, however, that this just
downloads the installers. A message will suggest that running setup.exe
will install the requested components but actually you have to go into
the Downloads\Windows Kits\10\StandaloneSDK\Installers directory to
run the x86 and x64 debugger installers.

Then install depot_tools and run:

> python depot_tools\win_toolchain\package_from_installed.py 2015

The package is uploaded with this syntax (replace hash.zip):

> python depot_tools\third_party\gsutil\gsutil cp hash.zip
gs://chrome-wintoolchain/hash.zip

This process arguably packages up more files than are needed. The
sys32\api_ms-* files can't actually be used in this form - the Universal
Windows 10 C Runtime needs to be installed. These files are also
different on difference OSes, so packaging them doesn't really make
sense. Also the VC\lib\onecore and VC\redist\onecore files are large and
appear to be unneeded. But, removing these is not important.

BUG=440500

Committed: https://crrev.com/94c4e7106c3783cf35f5fe00561ce445382fc0ae
Cr-Commit-Position: refs/heads/master@{#368760}
==========

[commit-bot: I haz the power, 2016-01-12 01:32:36]

Patchset 2 (id:??) landed as
https://crrev.com/94c4e7106c3783cf35f5fe00561ce445382fc0ae
Cr-Commit-Position: refs/heads/master@{#368760}