Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1576863002: Update Selection IDL TODOs to match nullability change in spec (Closed)

Created:
4 years, 11 months ago by philipj_slow
Modified:
4 years, 11 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Selection IDL TODOs to match nullability change in spec The node arguments of collapse and setPosition were made nullable: https://github.com/w3c/selection-api/issues/64 Also move out the optional arguments issues into a single comment: https://github.com/w3c/selection-api/issues/30 BUG=391673 R=yoichio@chromium.org Committed: https://crrev.com/062f1c74e4f2fd79d0a85bddc046db9c17016ed3 Cr-Commit-Position: refs/heads/master@{#368825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M third_party/WebKit/Source/core/editing/Selection.idl View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
philipj_slow
4 years, 11 months ago (2016-01-11 09:48:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576863002/1
4 years, 11 months ago (2016-01-11 09:48:29 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-11 11:03:59 UTC) #5
yoichio
lgtm
4 years, 11 months ago (2016-01-12 05:14:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576863002/1
4 years, 11 months ago (2016-01-12 08:24:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 08:42:48 UTC) #9
commit-bot: I haz the power
Failed to apply the patch.
4 years, 11 months ago (2016-01-12 08:43:05 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 08:44:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/062f1c74e4f2fd79d0a85bddc046db9c17016ed3
Cr-Commit-Position: refs/heads/master@{#368825}

Powered by Google App Engine
This is Rietveld 408576698