Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: third_party/WebKit/Source/core/editing/Selection.idl

Issue 1576863002: Update Selection IDL TODOs to match nullability change in spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/Selection.idl
diff --git a/third_party/WebKit/Source/core/editing/Selection.idl b/third_party/WebKit/Source/core/editing/Selection.idl
index ca677de819c25512c3737dd63b7eaceebc71502d..51c2879f4dd019f13fe6a95f63ced68cb611bbc0 100644
--- a/third_party/WebKit/Source/core/editing/Selection.idl
+++ b/third_party/WebKit/Source/core/editing/Selection.idl
@@ -30,6 +30,8 @@
// http://w3c.github.io/selection-api/#idl-def-Selection
// TODO(yoichio): All long types should be unsigned long. crbug.com/391673
+// TODO(philipj): No arguments are optional in the spec, but some should be:
+// https://github.com/w3c/selection-api/issues/30
[
ImplementedAs=DOMSelection,
WillBeGarbageCollected,
@@ -47,19 +49,14 @@
//void removeRange(Range range);
[MeasureAs=SelectionRemoveAllRanges] void removeAllRanges();
[MeasureAs=SelectionEmpty] void empty();
- // TODO(yoichio): The node argument should not be nullable. crbug.com/391673
- // TODO(philipj): The offset argument should not have a default value.
[MeasureAs=SelectionCollapse, RaisesException, LegacyInterfaceTypeChecking] void collapse(Node? node, optional long offset = 0);
- // TODO(yoichio): The node argument should not be nullable. crbug.com/391673
- // TODO(philipj): The offset argument should not have a default value.
[ImplementedAs=collapse, MeasureAs=SelectionSetPosition, RaisesException, LegacyInterfaceTypeChecking] void setPosition(Node? node, optional long offset = 0);
[MeasureAs=SelectionCollapseToStart, RaisesException] void collapseToStart();
[MeasureAs=SelectionCollapseToEnd, RaisesException] void collapseToEnd();
- // TODO(philipj): The offset argument should not have a default value.
[MeasureAs=SelectionExtend, RaisesException] void extend(Node node, optional long offset = 0);
// TODO(philipj): The arguments should be anchorNode, anchorOffset,
- // focusNode and focusOffset, and none of them should be optional or
- // nullable.
+ // focusNode and focusOffset, and none of them are optional or nullable in
+ // the spec.
[MeasureAs=SelectionSetBaseAndExtent, RaisesException, LegacyInterfaceTypeChecking] void setBaseAndExtent([Default=Undefined] optional Node? baseNode,
[Default=Undefined] optional long baseOffset,
[Default=Undefined] optional Node? extentNode,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698