Update Selection IDL TODOs to match nullability change in spec

third_party/WebKit/Source/core/editing/Selection.idl

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 12 matching lines @@
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 // http://w3c.github.io/selection-api/#idl-def-Selection
 
 // TODO(yoichio): All long types should be unsigned long. crbug.com/391673
+// TODO(philipj): No arguments are optional in the spec, but some should be:
+// https://github.com/w3c/selection-api/issues/30
 [
     ImplementedAs=DOMSelection,
     WillBeGarbageCollected,
 ] interface Selection {
     [MeasureAs=SelectionAnchorNode] readonly attribute Node? anchorNode;
     [MeasureAs=SelectionAnchorOffset] readonly attribute long anchorOffset;
     [MeasureAs=SelectionFocusNode] readonly attribute Node? focusNode;
     [MeasureAs=SelectionFocusOffset] readonly attribute long focusOffset;
     [MeasureAs=SelectionIsCollapsed] readonly attribute boolean isCollapsed;
     [MeasureAs=SelectionRangeCount] readonly attribute long rangeCount;
     [MeasureAs=SelectionType] readonly attribute DOMString type;
     [MeasureAs=SelectionGetRangeAt, RaisesException] Range getRangeAt(long index);
     [MeasureAs=SelectionAddRange] void addRange(Range range);
     // TODO(yoichio): Implement removeRange. crbug.com/391673
     //void removeRange(Range range);
     [MeasureAs=SelectionRemoveAllRanges] void removeAllRanges();
     [MeasureAs=SelectionEmpty] void empty();
-    // TODO(yoichio): The node argument should not be nullable. crbug.com/391673
-    // TODO(philipj): The offset argument should not have a default value.
     [MeasureAs=SelectionCollapse, RaisesException, LegacyInterfaceTypeChecking] void collapse(Node? node, optional long offset = 0);
-    // TODO(yoichio): The node argument should not be nullable. crbug.com/391673
-    // TODO(philipj): The offset argument should not have a default value.
     [ImplementedAs=collapse, MeasureAs=SelectionSetPosition, RaisesException, LegacyInterfaceTypeChecking] void setPosition(Node? node, optional long offset = 0);
     [MeasureAs=SelectionCollapseToStart, RaisesException] void collapseToStart();
     [MeasureAs=SelectionCollapseToEnd, RaisesException] void collapseToEnd();
-    // TODO(philipj): The offset argument should not have a default value.
     [MeasureAs=SelectionExtend, RaisesException] void extend(Node node, optional long offset = 0);
     // TODO(philipj): The arguments should be anchorNode, anchorOffset,
-    // focusNode and focusOffset, and none of them should be optional or
-    // nullable.
+    // focusNode and focusOffset, and none of them are optional or nullable in
+    // the spec.
     [MeasureAs=SelectionSetBaseAndExtent, RaisesException, LegacyInterfaceTypeChecking] void setBaseAndExtent([Default=Undefined] optional Node? baseNode,
                                                                                                               [Default=Undefined] optional long baseOffset,
                                                                                                               [Default=Undefined] optional Node? extentNode,
                                                                                                               [Default=Undefined] optional long extentOffset);
     [MeasureAs=SelectionSelectAllChildren, RaisesException] void selectAllChildren(Node node);
     [MeasureAs=SelectionDeleteDromDocument, CustomElementCallbacks] void deleteFromDocument();
     [MeasureAs=SelectionContainsNode] boolean containsNode(Node node, optional boolean allowPartialContainment = false);
     // TODO(philipj): The spec does not use [NotEnumerable]. See also:
     // https://codereview.chromium.org/345983004/
     // https://www.w3.org/Bugs/Public/show_bug.cgi?id=26179
     [MeasureAs=SelectionDOMString, NotEnumerable] stringifier DOMString();
 
     // Non-standard APIs
 
     // https://github.com/w3c/selection-api/issues/34
     [MeasureAs=SelectionBaseNode] readonly attribute Node? baseNode;
     [MeasureAs=SelectionBaseOffset] readonly attribute long baseOffset;
     [MeasureAs=SelectionExtentNode] readonly attribute Node? extentNode;
     [MeasureAs=SelectionExtentOffset] readonly attribute long extentOffset;
 
     // https://github.com/w3c/selection-api/issues/37
     [MeasureAs=SelectionModify] void modify([Default=Undefined] optional DOMString alter,
                                             [Default=Undefined] optional DOMString direction,
                                             [Default=Undefined] optional DOMString granularity);
 };