Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: net/quic/quic_headers_stream_test.cc

Issue 1576623002: relnote: quic_supports_push_promise should be disabled by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@9_CL_111542509
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/quic/quic_flags.cc ('K') | « net/quic/quic_flags.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_headers_stream_test.cc
diff --git a/net/quic/quic_headers_stream_test.cc b/net/quic/quic_headers_stream_test.cc
index 1f4d586b4050650ef60187aa7f4e394cf4a0286a..2425683a5b485ad11f7d8805e00bc484e69053fd 100644
--- a/net/quic/quic_headers_stream_test.cc
+++ b/net/quic/quic_headers_stream_test.cc
@@ -115,6 +115,7 @@ vector<TestParams> GetTestParams() {
params.push_back(TestParams(version, Perspective::IS_CLIENT));
params.push_back(TestParams(version, Perspective::IS_SERVER));
}
+ FLAGS_quic_supports_push_promise = true;
return params;
}
@@ -339,7 +340,8 @@ TEST_P(QuicHeadersStreamTest, ProcessRawData) {
}
TEST_P(QuicHeadersStreamTest, ProcessPushPromise) {
- FLAGS_quic_supports_push_promise = true;
+ if (perspective() == Perspective::IS_SERVER)
+ return;
for (QuicStreamId stream_id = kClientDataStreamId1;
stream_id < kClientDataStreamId3; stream_id += 2) {
QuicStreamId promised_stream_id = NextPromisedStreamId();
@@ -371,10 +373,8 @@ TEST_P(QuicHeadersStreamTest, ProcessPushPromise) {
}
TEST_P(QuicHeadersStreamTest, PushPromiseOutOfOrder) {
- FLAGS_quic_supports_push_promise = true;
- if (perspective() == Perspective::IS_SERVER) {
+ if (perspective() == Perspective::IS_SERVER)
return;
- }
QuicStreamId promised_stream_id = NextPromisedStreamId();
QuicStreamId stream_id = kClientDataStreamId1;
« net/quic/quic_flags.cc ('K') | « net/quic/quic_flags.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698