relnote: quic_supports_push_promise should be disabled by default.

net/quic/quic_headers_stream_test.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_headers_stream.h"
 
 #include "net/quic/quic_utils.h"
 #include "net/quic/spdy_utils.h"
 #include "net/quic/test_tools/quic_connection_peer.h"
 #include "net/quic/test_tools/quic_spdy_session_peer.h"
@@ skipping 97 matching lines @@
 };
 
 // Constructs various test permutations.
 vector<TestParams> GetTestParams() {
   vector<TestParams> params;
   QuicVersionVector all_supported_versions = QuicSupportedVersions();
   for (const QuicVersion version : all_supported_versions) {
     params.push_back(TestParams(version, Perspective::IS_CLIENT));
     params.push_back(TestParams(version, Perspective::IS_SERVER));
   }
+  FLAGS_quic_supports_push_promise = true;
   return params;
 }
 
 class QuicHeadersStreamTest : public ::testing::TestWithParam<TestParams> {
  public:
   QuicHeadersStreamTest()
       : connection_(new StrictMock<MockConnection>(&helper_,
                                                    perspective(),
                                                    GetVersion())),
         session_(connection_),
@@ skipping 204 matching lines @@
         stream_frame_.frame_length = frame->size();
         headers_stream_->OnStreamFrame(stream_frame_);
         stream_frame_.offset += frame->size();
         CheckHeaders();
       }
     }
   }
 }
 
 TEST_P(QuicHeadersStreamTest, ProcessPushPromise) {
-  FLAGS_quic_supports_push_promise = true;
+  if (perspective() == Perspective::IS_SERVER)
+    return;
   for (QuicStreamId stream_id = kClientDataStreamId1;
        stream_id < kClientDataStreamId3; stream_id += 2) {
     QuicStreamId promised_stream_id = NextPromisedStreamId();
     scoped_ptr<SpdySerializedFrame> frame;
     SpdyPushPromiseIR push_promise(stream_id, promised_stream_id);
     push_promise.set_header_block(headers_);
     frame.reset(framer_.SerializeFrame(push_promise));
     if (perspective() == Perspective::IS_SERVER) {
       EXPECT_CALL(*connection_, SendConnectionCloseWithDetails(
                                     QUIC_INVALID_HEADERS_STREAM_DATA,
@@ skipping 11 matching lines @@
     stream_frame_.frame_length = frame->size();
     headers_stream_->OnStreamFrame(stream_frame_);
     if (perspective() == Perspective::IS_CLIENT) {
       stream_frame_.offset += frame->size();
       CheckHeaders();
     }
   }
 }
 
 TEST_P(QuicHeadersStreamTest, PushPromiseOutOfOrder) {
-  FLAGS_quic_supports_push_promise = true;
-  if (perspective() == Perspective::IS_SERVER) {
+  if (perspective() == Perspective::IS_SERVER)
     return;
-  }
 
   QuicStreamId promised_stream_id = NextPromisedStreamId();
   QuicStreamId stream_id = kClientDataStreamId1;
 
   scoped_ptr<SpdySerializedFrame> frame;
   SpdyPushPromiseIR push_promise(stream_id, promised_stream_id);
   push_promise.set_header_block(headers_);
   frame.reset(framer_.SerializeFrame(push_promise));
   EXPECT_CALL(session_, OnPromiseHeaders(stream_id, _))
       .WillRepeatedly(WithArgs<1>(
@@ skipping 237 matching lines @@
 }
 
 TEST_P(QuicHeadersStreamTest, NoConnectionLevelFlowControl) {
   EXPECT_FALSE(ReliableQuicStreamPeer::StreamContributesToConnectionFlowControl(
       headers_stream_));
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace net