net/quic/quic_flags.cc - Issue 1576623002: relnote: quic_supports_push_promise should be disabled by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_flags.cc

Issue 1576623002: relnote: quic_supports_push_promise should be disabled by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@9_CL_111542509

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_flags.cc

diff --git a/net/quic/quic_flags.cc b/net/quic/quic_flags.cc

index cee399f995e0647a18f97b9db1dbdf1a59afce85..580b8fb2125e19fd4429cc74a9d7f775d8091ba8 100644

--- a/net/quic/quic_flags.cc

+++ b/net/quic/quic_flags.cc

@@ -120,7 +120,7 @@ bool FLAGS_quic_require_fix = true;

bool FLAGS_quic_supports_trailers = true;

// If true, headers stream will support receiving PUSH_PROMISE frames.

-bool FLAGS_quic_supports_push_promise = true;

+bool FLAGS_quic_supports_push_promise = false;

Ryan Hamilton 2016/01/10 23:11:12 Can you chat with buck to make sure we're on the s

// Fixes a bug in QUIC_VERSION_26 by always using the primary config when

// getting the proof of possession.

« no previous file with comments | « no previous file | net/quic/quic_headers_stream_test.cc » ('j') | no next file with comments »