Issue 1576623002: relnote: quic_supports_push_promise should be disabled by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1576623002: relnote: quic_supports_push_promise should be disabled by default. (Closed)

Created:
4 years, 11 months ago by Zhongyi Shi

Modified:
4 years, 11 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@9_CL_111542509

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

relnote: quic_supports_push_promise should be disabled by default. Merge internal change: 111560672 BUG=

Patch Set 1 #

Total comments: 1

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	net/quic/quic_flags.cc	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	net/quic/quic_headers_stream_test.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Depends on Patchset:

Issue 1572013002 Patch 1

Dependent Patchsets:

Issue 1576553003 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ryan Hamilton

4 years, 11 months ago (2016-01-10 23:11:13 UTC) #3

lgtm

https://codereview.chromium.org/1576623002/diff/1/net/quic/quic_flags.cc
File net/quic/quic_flags.cc (right):

https://codereview.chromium.org/1576623002/diff/1/net/quic/quic_flags.cc#newc...
net/quic/quic_flags.cc:123: bool FLAGS_quic_supports_push_promise = false;
Can you chat with buck to make sure we're on the same page about the flag in
chrome.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages