Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3311)

Unified Diff: chrome/browser/ui/startup/default_browser_prompt.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes mistake in previous patch set. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/pdf/adobe_reader_info_win.cc ('k') | chrome/common/chrome_content_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/startup/default_browser_prompt.cc
diff --git a/chrome/browser/ui/startup/default_browser_prompt.cc b/chrome/browser/ui/startup/default_browser_prompt.cc
index 0f13478f3ca7d9d75a362a8bfc712507776061f2..b5710ea423076d36e0dc4251987a8857b1303102 100644
--- a/chrome/browser/ui/startup/default_browser_prompt.cc
+++ b/chrome/browser/ui/startup/default_browser_prompt.cc
@@ -314,9 +314,9 @@ void ShowDefaultBrowserPrompt(Profile* profile, HostDesktopType desktop_type) {
prefs::kBrowserSuppressDefaultBrowserPrompt);
const Version disable_version(disable_version_string);
DCHECK(disable_version_string.empty() || disable_version.IsValid());
- if (disable_version.IsValid()) {
- if (disable_version.Equals(Version(version_info::GetVersionNumber())))
- show_prompt = false;
+ if (disable_version.IsValid() &&
+ disable_version == Version(version_info::GetVersionNumber())) {
+ show_prompt = false;
}
}
« no previous file with comments | « chrome/browser/ui/pdf/adobe_reader_info_win.cc ('k') | chrome/common/chrome_content_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698