Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1583)

Unified Diff: chrome/browser/ui/pdf/adobe_reader_info_win.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes mistake in previous patch set. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/pdf/adobe_reader_info_win.cc
diff --git a/chrome/browser/ui/pdf/adobe_reader_info_win.cc b/chrome/browser/ui/pdf/adobe_reader_info_win.cc
index 7f63daa8729f7095cbe1a2be0dd8fa51cb084c1b..86feb5f8f24639ef04f16836b3e532e9ac0d6477 100644
--- a/chrome/browser/ui/pdf/adobe_reader_info_win.cc
+++ b/chrome/browser/ui/pdf/adobe_reader_info_win.cc
@@ -184,5 +184,6 @@ bool IsAdobeReaderUpToDate() {
base::ReplaceSubstringsAfterOffset(&reader_version, 0, from, to);
}
base::Version file_version(reader_version);
- return file_version.IsValid() && !file_version.IsOlderThan(kSecureVersion);
+ return file_version.IsValid() &&
+ file_version >= base::Version(kSecureVersion);
}
« no previous file with comments | « chrome/browser/extensions/extension_sync_service.cc ('k') | chrome/browser/ui/startup/default_browser_prompt.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698