Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5125)

Unified Diff: chrome/common/chrome_content_client.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes mistake in previous patch set. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/startup/default_browser_prompt.cc ('k') | chrome/installer/setup/install.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_content_client.cc
diff --git a/chrome/common/chrome_content_client.cc b/chrome/common/chrome_content_client.cc
index 50064fb5e0a513bb532e02e2bb0c39ccde5a426c..a956d00c50fb119e58f3dfda3aaa367ce239bb12 100644
--- a/chrome/common/chrome_content_client.cc
+++ b/chrome/common/chrome_content_client.cc
@@ -470,9 +470,9 @@ content::PepperPluginInfo* ChromeContentClient::FindMostRecentPlugin(
Version version_x(x->version);
Version version_y(y->version);
DCHECK(version_x.IsValid() && version_y.IsValid());
- if (version_x.Equals(version_y))
+ if (version_x == version_y)
return !x->is_debug && y->is_debug;
- return version_x.IsOlderThan(y->version);
+ return version_x < version_y;
});
return it != plugins.end() ? *it : nullptr;
}
« no previous file with comments | « chrome/browser/ui/startup/default_browser_prompt.cc ('k') | chrome/installer/setup/install.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698