Allow GPU channels to be created when using SwiftShader

Allow GPU channels to be created when using SwiftShader

When using SwiftShader, we still need a GPU channel for webgl, but we need to
make sure the renderer compositor falls back to software.

BUG=576500
Committed: https://crrev.com/990d8ea8ff1f46b1f0dde0f85677e1c27cfa5482
Cr-Commit-Position: refs/heads/master@{#368882}

[piman, 2016-01-12 03:20:26]

piman@chromium.org changed reviewers:
+ jbauman@chromium.org

[jbauman, 2016-01-12 03:24:58]

https://codereview.chromium.org/1575293002/diff/1/content/renderer/render_wid...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/1575293002/diff/1/content/renderer/render_wid...
content/renderer/render_widget.cc:993: use_software = true;
software_rendering is always false for me because
GpuDataManagerImplPrivate::UpdateGpuInfo refuses to update its gpu info from the
gpu if SwiftShader is being used. Maybe
GpuDataManagerImplPrivate::EnableSwiftShaderIfNecessary should modify
gpu_info.software_rendering in that case.

[piman, 2016-01-12 04:39:47]

On 2016/01/12 03:24:58, jbauman wrote:
>
https://codereview.chromium.org/1575293002/diff/1/content/renderer/render_wid...
> File content/renderer/render_widget.cc (right):
> 
>
https://codereview.chromium.org/1575293002/diff/1/content/renderer/render_wid...
> content/renderer/render_widget.cc:993: use_software = true;
> software_rendering is always false for me because
> GpuDataManagerImplPrivate::UpdateGpuInfo refuses to update its gpu info from
the
> gpu if SwiftShader is being used. Maybe
> GpuDataManagerImplPrivate::EnableSwiftShaderIfNecessary should modify
> gpu_info.software_rendering in that case.

PTAL, in the latest patch I'm passing the GPUInfo directly from the
GpuProcessHost to the callback, so that it's not mangled by the
GpuDataManagerImpl. It seems a bit less awkward than trying to twiddle the GDMIP
state in various ways.

Another possibility is to pass the value of CanUseGpuBrowserCompositor with the
GpuHostMsg_EstablishGpuChannel reply from the browser. I think you're right that
in the long term passing it via the BeginFrame IPC is the right thing to do, to
avoid all races and redundant logic.

[jbauman, 2016-01-12 06:12:16]

On 2016/01/12 04:39:47, piman (Slow to review) wrote:
> On 2016/01/12 03:24:58, jbauman wrote:
> >
>
https://codereview.chromium.org/1575293002/diff/1/content/renderer/render_wid...
> > File content/renderer/render_widget.cc (right):
> > 
> >
>
https://codereview.chromium.org/1575293002/diff/1/content/renderer/render_wid...
> > content/renderer/render_widget.cc:993: use_software = true;
> > software_rendering is always false for me because
> > GpuDataManagerImplPrivate::UpdateGpuInfo refuses to update its gpu info from
> the
> > gpu if SwiftShader is being used. Maybe
> > GpuDataManagerImplPrivate::EnableSwiftShaderIfNecessary should modify
> > gpu_info.software_rendering in that case.
> 
> PTAL, in the latest patch I'm passing the GPUInfo directly from the
> GpuProcessHost to the callback, so that it's not mangled by the
> GpuDataManagerImpl. It seems a bit less awkward than trying to twiddle the
GDMIP
> state in various ways.
> 
> Another possibility is to pass the value of CanUseGpuBrowserCompositor with
the
> GpuHostMsg_EstablishGpuChannel reply from the browser. I think you're right
that
> in the long term passing it via the BeginFrame IPC is the right thing to do,
to
> avoid all races and redundant logic.

lgtm. This seems like a reasonable way to do it for now.

[piman, 2016-01-12 15:29:50]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-01-12 15:30:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1575293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1575293002/20001

[commit-bot: I haz the power, 2016-01-12 15:35:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-12 15:36:37]

Description was changed from

==========
Allow GPU channels to be created when using SwiftShader

When using SwiftShader, we still need a GPU channel for webgl, but we need to
make sure the renderer compositor falls back to software.

BUG=576500
==========

to

==========
Allow GPU channels to be created when using SwiftShader

When using SwiftShader, we still need a GPU channel for webgl, but we need to
make sure the renderer compositor falls back to software.

BUG=576500

Committed: https://crrev.com/990d8ea8ff1f46b1f0dde0f85677e1c27cfa5482
Cr-Commit-Position: refs/heads/master@{#368882}
==========

[commit-bot: I haz the power, 2016-01-12 15:36:37]

Patchset 2 (id:??) landed as
https://crrev.com/990d8ea8ff1f46b1f0dde0f85677e1c27cfa5482
Cr-Commit-Position: refs/heads/master@{#368882}