Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1573913008: VisualBench: Make the Android SDL app start without cmdline arguments (Closed)

Created:
4 years, 11 months ago by Kimmo Kinnunen
Modified:
4 years, 11 months ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org, Chris Dalton
Base URL:
https://skia.googlesource.com/skia.git@android-visualbench-surface-fail-check
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

VisualBench: Make the Android SDL app start without cmdline arguments Make the Android SDL VisualBench start even if it is started without command-line arguments. Also makes it start when started by pressing the icon. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1573913008 Committed: https://skia.googlesource.com/skia/+/721772ec49d45e3c4b72fb141b6ad7b228356302

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M platform_tools/android/apps/visualbenchsdl/src/main/java/com/skia/VisualBenchActivity.java View 1 chunk +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Kimmo Kinnunen
4 years, 11 months ago (2016-01-14 11:06:48 UTC) #3
joshualitt
On 2016/01/14 11:06:48, Kimmo Kinnunen wrote: lgtm, thanks for this!
4 years, 11 months ago (2016-01-14 14:04:51 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1582313002 Patch 1). Please resolve the dependency and ...
4 years, 11 months ago (2016-01-14 14:06:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573913008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573913008/40001
4 years, 11 months ago (2016-01-14 19:41:39 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 19:54:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/721772ec49d45e3c4b72fb141b6ad7b228356302

Powered by Google App Engine
This is Rietveld 408576698