Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: platform_tools/android/apps/visualbenchsdl/src/main/java/com/skia/VisualBenchActivity.java

Issue 1573913008: VisualBench: Make the Android SDL app start without cmdline arguments (Closed) Base URL: https://skia.googlesource.com/skia.git@android-visualbench-surface-fail-check
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/apps/visualbenchsdl/src/main/java/com/skia/VisualBenchActivity.java
diff --git a/platform_tools/android/apps/visualbenchsdl/src/main/java/com/skia/VisualBenchActivity.java b/platform_tools/android/apps/visualbenchsdl/src/main/java/com/skia/VisualBenchActivity.java
index f54b7d97466d040f4cb50d7bae2d90a92718f864..894a9b33916f5d1cb5f44217085b1fe5e6904901 100644
--- a/platform_tools/android/apps/visualbenchsdl/src/main/java/com/skia/VisualBenchActivity.java
+++ b/platform_tools/android/apps/visualbenchsdl/src/main/java/com/skia/VisualBenchActivity.java
@@ -13,10 +13,10 @@ import android.content.Intent;
public class VisualBenchActivity extends SDLActivity {
protected String[] getArguments() {
- // intent get intent extras if triggered from the command line
- Intent intent = this.getIntent();
- String flags = intent.getStringExtra("cmdLineFlags");
-
- return flags.split("\\s+");
+ String flags = this.getIntent().getStringExtra("cmdLineFlags");
+ if (flags != null && !flags.isEmpty()) {
+ return flags.split("\\s+");
+ }
+ return new String[0];
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698