Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1582313002: VisualBench: Use first succeeding EGL API (Closed)

Created:
4 years, 11 months ago by Kimmo Kinnunen
Modified:
4 years, 11 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@android-sampleapp-paths
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

VisualBench: Use first succeeding EGL API Fix initialization of the app window by using the first EGL context that succeeds, not the last one. Fixes the window creation in some cases on devices that support OpenGL and OpenGL ES. Also check EGL call results. BUG=skia:4733 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1582313002 Committed: https://skia.googlesource.com/skia/+/fe09119dd2acb43bb9986e6edeef3a480b539473

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp View 1 3 chunks +28 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
Kimmo Kinnunen
4 years, 11 months ago (2016-01-14 11:00:52 UTC) #3
joshualitt
On 2016/01/14 11:00:52, Kimmo Kinnunen wrote: lgtm
4 years, 11 months ago (2016-01-14 14:04:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582313002/20001
4 years, 11 months ago (2016-01-14 14:09:33 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 17:12:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fe09119dd2acb43bb9986e6edeef3a480b539473

Powered by Google App Engine
This is Rietveld 408576698