Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1573243011: Refactor der::Input helper methods into new constructors (Closed)

Created:
4 years, 11 months ago by nharper
Modified:
4 years, 11 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor der::Input helper methods into new constructors Committed: https://crrev.com/f5c6253ac16f742fadffe210795d50b9344383ae Cr-Commit-Position: refs/heads/master@{#369311}

Patch Set 1 #

Patch Set 2 : Add documentation #

Total comments: 13

Patch Set 3 : fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -193 lines) Patch
M net/cert/asn1_util.cc View 5 chunks +6 lines, -15 lines 0 comments Download
M net/cert/internal/certificate_policies_unittest.cc View 10 chunks +14 lines, -28 lines 0 comments Download
M net/cert/internal/name_constraints_unittest.cc View 57 chunks +87 lines, -93 lines 0 comments Download
M net/cert/internal/parse_certificate_unittest.cc View 8 chunks +19 lines, -21 lines 0 comments Download
M net/cert/internal/test_helpers.h View 1 chunk +0 lines, -10 lines 0 comments Download
M net/cert/internal/test_helpers.cc View 1 chunk +1 line, -5 lines 0 comments Download
M net/cert/internal/verify_certificate_chain.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M net/cert/internal/verify_certificate_chain_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/cert/internal/verify_signed_data_unittest.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M net/der/input.h View 1 2 3 chunks +21 lines, -1 line 0 comments Download
M net/der/input.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
nharper
Add documentation
4 years, 11 months ago (2016-01-13 22:34:24 UTC) #1
nharper
4 years, 11 months ago (2016-01-13 22:35:27 UTC) #3
eroman
lgtm https://codereview.chromium.org/1573243011/diff/20001/net/der/input.cc File net/der/input.cc (right): https://codereview.chromium.org/1573243011/diff/20001/net/der/input.cc#newcode26 net/der/input.cc:26: : data_(reinterpret_cast<const uint8_t*>(s->data())), len_(s->size()) {} Could also delegate ...
4 years, 11 months ago (2016-01-13 22:54:01 UTC) #4
nharper
fix nits
4 years, 11 months ago (2016-01-13 23:04:28 UTC) #5
nharper
https://codereview.chromium.org/1573243011/diff/20001/net/der/input.cc File net/der/input.cc (right): https://codereview.chromium.org/1573243011/diff/20001/net/der/input.cc#newcode26 net/der/input.cc:26: : data_(reinterpret_cast<const uint8_t*>(s->data())), len_(s->size()) {} On 2016/01/13 22:54:00, eroman ...
4 years, 11 months ago (2016-01-13 23:04:48 UTC) #6
eroman
lgtm https://codereview.chromium.org/1573243011/diff/20001/net/der/input.h File net/der/input.h (right): https://codereview.chromium.org/1573243011/diff/20001/net/der/input.h#newcode88 net/der/input.h:88: Input(std::string) = delete; On 2016/01/13 23:04:47, nharper wrote: ...
4 years, 11 months ago (2016-01-13 23:21:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573243011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573243011/40001
4 years, 11 months ago (2016-01-13 23:29:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
4 years, 11 months ago (2016-01-14 01:40:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573243011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573243011/40001
4 years, 11 months ago (2016-01-14 01:47:56 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-14 03:42:31 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 03:43:25 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f5c6253ac16f742fadffe210795d50b9344383ae
Cr-Commit-Position: refs/heads/master@{#369311}

Powered by Google App Engine
This is Rietveld 408576698