Refactor der::Input helper methods into new constructors

net/socket/ssl_client_socket_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/ssl_client_socket.h"
 
 #include <utility>
 
 #include "base/callback_helpers.h"
 #include "base/location.h"
@@ skipping 2365 matching lines @@
   SSLInfo result;
   ASSERT_TRUE(sock_->GetSSLInfo(&result));
 
   EXPECT_FALSE(result.cert_status & CERT_STATUS_IS_EV);
   EXPECT_TRUE(result.cert_status & CERT_STATUS_CT_COMPLIANCE_FAILED);
 }
 
 namespace {
 
 bool IsValidOCSPResponse(const base::StringPiece& input) {
-  der::Parser parser(der::Input(reinterpret_cast<const uint8_t*>(input.data()),
-                                input.length()));
+  der::Parser parser((der::Input(input)));

[eroman, 2016/01/13 22:54:00]

yay c++ parsing!

[nharper, 2016/01/13 23:04:48]

Yay indeed :P
There were a few other vexing parses that needed extra parens in this cleanup.

   der::Parser sequence;
   return parser.ReadSequence(&sequence) && !parser.HasMore() &&
          sequence.SkipTag(der::kEnumerated) &&
          sequence.SkipTag(der::kTagContextSpecific | der::kTagConstructed |
                           0) &&
          !sequence.HasMore();
 }
 
 }  // namespace
 
@@ skipping 837 matching lines @@
   int rv;
   ASSERT_TRUE(CreateAndConnectSSLClientSocket(client_config, &rv));
   EXPECT_EQ(OK, rv);
 
   std::string proto;
   EXPECT_EQ(SSLClientSocket::kNextProtoUnsupported,
             sock_->GetNextProto(&proto));
 }
 
 }  // namespace net