Refactor der::Input helper methods into new constructors

net/der/input.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string.h>
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "net/der/input.h"
 
 namespace net {
 
 namespace der {
 
 Input::Input() : data_(nullptr), len_(0) {
 }
 
 Input::Input(const uint8_t* data, size_t len) : data_(data), len_(len) {
 }
 
+Input::Input(const base::StringPiece& in)
+    : data_(reinterpret_cast<const uint8_t*>(in.data())), len_(in.length()) {}
+
+Input::Input(const std::string* s)
+    : data_(reinterpret_cast<const uint8_t*>(s->data())), len_(s->size()) {}

[eroman, 2016/01/13 22:54:00]

Could also delegate to stringpiece ctor
   : Input(StringPiece(*s))

[nharper, 2016/01/13 23:04:47]

That looks a little cleaner. Done.

+
 bool Input::Equals(const Input& other) const {
   if (len_ != other.len_)
     return false;
   return memcmp(data_, other.data_, len_) == 0;
 }
 
 std::string Input::AsString() const {
   return std::string(reinterpret_cast<const char*>(data_), len_);
 }
 
+base::StringPiece Input::AsStringPiece() const {
+  return base::StringPiece(reinterpret_cast<const char*>(data_), len_);
+}
+
 bool operator<(const Input& lhs, const Input& rhs) {
   return std::lexicographical_compare(
       lhs.UnsafeData(), lhs.UnsafeData() + lhs.Length(), rhs.UnsafeData(),
       rhs.UnsafeData() + rhs.Length());
 }
 
 ByteReader::ByteReader(const Input& in)
     : data_(in.UnsafeData()), len_(in.Length()) {
 }
 
@@ skipping 57 matching lines @@
 
 Mark::Mark(const uint8_t* ptr) : ptr_(ptr) {
 }
 
 Mark::Mark() : ptr_(nullptr) {
 }
 
 }  // namespace der
 
 }  // namespace net