Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1572863003: Fix the g++ build. (Closed)

Created:
4 years, 11 months ago by Jim Stichnoth
Modified:
4 years, 11 months ago
Reviewers:
Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the g++ build. It turns out that the g++ test build, initiated by "make presubmit", was actually using clang++ for the build. This fixes the makefile, plus the code that actually produces errors under the g++ build. BUG= none TBR=jpp Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=caeaa27b18e94cbad635dbe21da87e816a35c7da

Patch Set 1 #

Patch Set 2 : Remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -57 lines) Patch
M Makefile.standalone View 2 chunks +14 lines, -11 lines 0 comments Download
M src/IceELFObjectWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceRegistersARM32.h View 1 chunk +12 lines, -12 lines 0 comments Download
M src/IceTargetLoweringX8632Traits.h View 1 chunk +11 lines, -11 lines 0 comments Download
M src/IceTargetLoweringX8664Traits.h View 1 chunk +11 lines, -11 lines 0 comments Download
M src/IceTargetLoweringX86Base.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Jim Stichnoth
I'd be happy if there were a better BoolFolding solution.
4 years, 11 months ago (2016-01-09 17:04:29 UTC) #3
Jim Stichnoth
I'd be happy if there were a better BoolFolding solution.
4 years, 11 months ago (2016-01-09 17:04:54 UTC) #4
Jim Stichnoth
4 years, 11 months ago (2016-01-10 20:53:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
caeaa27b18e94cbad635dbe21da87e816a35c7da (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698