src/IceELFObjectWriter.cpp - Issue 1572863003: Fix the g++ build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceELFObjectWriter.cpp

Issue 1572863003: Fix the g++ build. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Remove comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceELFObjectWriter.cpp

diff --git a/src/IceELFObjectWriter.cpp b/src/IceELFObjectWriter.cpp

index cb36e3d92a0cf7aa68fdce4af2db63d859677a85..611121ad094c144cf7c4baba4c828d97a860c6b0 100644

--- a/src/IceELFObjectWriter.cpp

+++ b/src/IceELFObjectWriter.cpp

@@ -330,7 +330,7 @@ void ELFObjectWriter::writeDataOfType(SectionType ST,

case ROData: {

const IceString SectionName =

MangleSectionName(IsPIC ? ".data.rel.ro" : ".rodata", SectionSuffix);

- const Elf64_Xword ShFlags = SHF_ALLOC | (IsPIC ? SHF_WRITE : 0);

+ const Elf64_Xword ShFlags = IsPIC ? (SHF_ALLOC | SHF_WRITE) : SHF_ALLOC;

Section = createSection<ELFDataSection>(SectionName, SHT_PROGBITS, ShFlags,

ShAddralign, ShEntsize);

Section->setFileOffset(alignFileOffset(ShAddralign));

« no previous file with comments | « Makefile.standalone ('k') | src/IceRegistersARM32.h » ('j') | no next file with comments »