Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1681)

Unified Diff: chrome/browser/ui/website_settings/chooser_bubble_delegate.h

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/chooser_bubble_delegate.h
diff --git a/chrome/browser/ui/website_settings/chooser_bubble_delegate.h b/chrome/browser/ui/website_settings/chooser_bubble_delegate.h
index 4e4f3bdf9198b11a4a1ca8db3a1964df96c34168..1dd40744a8db323360e1e750e3be79bab6dbb210 100644
--- a/chrome/browser/ui/website_settings/chooser_bubble_delegate.h
+++ b/chrome/browser/ui/website_settings/chooser_bubble_delegate.h
@@ -25,7 +25,7 @@ class Browser;
// into it is not allowed.
class ChooserBubbleDelegate : public BubbleDelegate {
public:
- explicit ChooserBubbleDelegate(Browser* browser);
+ explicit ChooserBubbleDelegate(content::RenderFrameHost* owner);
~ChooserBubbleDelegate() override;
// Since the set of options can change while the UI is visible an
@@ -55,6 +55,7 @@ class ChooserBubbleDelegate : public BubbleDelegate {
// BubbleDelegate:
std::string GetName() const override;
scoped_ptr<BubbleUi> BuildBubbleUi() override;
+ const content::RenderFrameHost* OwningFrame() const override;
// The number of options users can pick from. For example, it can be
// the number of USB/Bluetooth device names which are listed in the
@@ -82,6 +83,7 @@ class ChooserBubbleDelegate : public BubbleDelegate {
private:
Browser* browser_;
+ const content::RenderFrameHost* const owning_frame_;
Observer* observer_ = nullptr;
DISALLOW_COPY_AND_ASSIGN(ChooserBubbleDelegate);

Powered by Google App Engine
This is Rietveld 408576698