Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: chrome/browser/ui/website_settings/chooser_bubble_delegate.cc

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/chooser_bubble_delegate.cc
diff --git a/chrome/browser/ui/website_settings/chooser_bubble_delegate.cc b/chrome/browser/ui/website_settings/chooser_bubble_delegate.cc
index a3d1e99f4e0e9e5ee747e1c8ab2c7cc75099e750..8b209753ca10767380b26589ac56f26ee0fc7d5c 100644
--- a/chrome/browser/ui/website_settings/chooser_bubble_delegate.cc
+++ b/chrome/browser/ui/website_settings/chooser_bubble_delegate.cc
@@ -2,13 +2,21 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/website_settings/chooser_bubble_delegate.h"
+#include "content/public/browser/web_contents.h"
-ChooserBubbleDelegate::ChooserBubbleDelegate(Browser* browser)
- : browser_(browser) {}
+ChooserBubbleDelegate::ChooserBubbleDelegate(content::RenderFrameHost* owner)
+ : browser_(chrome::FindBrowserWithWebContents(
+ content::WebContents::FromRenderFrameHost(owner))),
+ owning_frame_(owner) {}
ChooserBubbleDelegate::~ChooserBubbleDelegate() {}
std::string ChooserBubbleDelegate::GetName() const {
return "ChooserBubble";
}
+
+const content::RenderFrameHost* ChooserBubbleDelegate::OwningFrame() const {
+ return owning_frame_;
+}
« no previous file with comments | « chrome/browser/ui/website_settings/chooser_bubble_delegate.h ('k') | chrome/browser/usb/usb_chooser_bubble_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698