chrome/browser/ui/extensions/extension_installed_bubble.cc - Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_installed_bubble.cc

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/extension_installed_bubble.h ('k') | chrome/browser/ui/website_settings/chooser_bubble_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_installed_bubble.cc

diff --git a/chrome/browser/ui/extensions/extension_installed_bubble.cc b/chrome/browser/ui/extensions/extension_installed_bubble.cc

index 74d65aa7642a6abe7fa71f2fd62953c7d24a84cf..2db22acb480bf44ee01312e5a21f82b1e6808fa8 100644

--- a/chrome/browser/ui/extensions/extension_installed_bubble.cc

+++ b/chrome/browser/ui/extensions/extension_installed_bubble.cc

@@ -212,6 +212,10 @@ std::string ExtensionInstalledBubble::GetName() const {

return "ExtensionInstalled";

}

+const content::RenderFrameHost* ExtensionInstalledBubble::OwningFrame() const {

+ return nullptr;

base::string16 ExtensionInstalledBubble::GetHowToUseDescription() const {

int message_id = 0;

base::string16 extra;