chrome/browser/ui/extensions/extension_installed_bubble.h - Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_installed_bubble.h

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/chrome_bubble_manager_unittest.cc ('k') | chrome/browser/ui/extensions/extension_installed_bubble.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_installed_bubble.h

diff --git a/chrome/browser/ui/extensions/extension_installed_bubble.h b/chrome/browser/ui/extensions/extension_installed_bubble.h

index e7f0305f975c5567dc71bbfea37d21e176393dcb..57c3e40be943fc39db778c0b39ab582973099e54 100644

--- a/chrome/browser/ui/extensions/extension_installed_bubble.h

+++ b/chrome/browser/ui/extensions/extension_installed_bubble.h

@@ -82,6 +82,7 @@ class ExtensionInstalledBubble : public BubbleDelegate {

scoped_ptr<BubbleUi> BuildBubbleUi() override;

bool ShouldClose(BubbleCloseReason reason) const override;

std::string GetName() const override;

+ const content::RenderFrameHost* OwningFrame() const override;

// Returns false if the bubble could not be shown immediately, because of an

// animation (eg. adding a new browser action to the toolbar).

« no previous file with comments | « chrome/browser/ui/chrome_bubble_manager_unittest.cc ('k') | chrome/browser/ui/extensions/extension_installed_bubble.cc » ('j') | no next file with comments »