components/bubble/bubble_delegate.h - Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bubble/bubble_delegate.h

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/bubble/bubble_delegate.h

diff --git a/components/bubble/bubble_delegate.h b/components/bubble/bubble_delegate.h

index d1f07e952902878665510f224328a53c2e5084fa..0983e471c6e4b855fe06c6c486a89e634850c804 100644

--- a/components/bubble/bubble_delegate.h

+++ b/components/bubble/bubble_delegate.h

@@ -23,7 +23,8 @@ class BubbleDelegate {

// Called by BubbleController to notify a bubble of an event that the bubble

// might want to close on. Return true if the bubble should close for the

- // specified reason.

+ // specified reason. If you return false, be sure not to reference frames that

+ // are destroyed before the bubble.

hcarmona 2016/01/11 19:07:22 I'm not 100% happy with this comment because it se

virtual bool ShouldClose(BubbleCloseReason reason) const;

// Called by BubbleController to notify a bubble that it has closed.

« components/bubble/bubble_close_reason.h ('K') | « components/bubble/bubble_close_reason.h ('k') | components/bubble/bubble_manager.h » ('j') | components/bubble/bubble_manager.h » ('J')