components/bubble/bubble_close_reason.h - Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bubble/bubble_close_reason.h

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/bubble/bubble_close_reason.h

diff --git a/components/bubble/bubble_close_reason.h b/components/bubble/bubble_close_reason.h

index 68e112d8f88e830256de0b0664330e07943ad987..f1f392204a5ea5aafe08c499ba4ea83a87f0c02c 100644

--- a/components/bubble/bubble_close_reason.h

+++ b/components/bubble/bubble_close_reason.h

@@ -36,6 +36,9 @@ enum BubbleCloseReason {

// The user selected a negative response in the bubble.

BUBBLE_CLOSE_CANCELED,

+ // A frame was closed, so references in the bubble may be invalid.

hcarmona 2016/01/11 19:07:22 Let's be more specific here about what references

+ BUBBLE_CLOSE_FRAME_DESTROYED,

};

#endif // COMPONENTS_BUBBLE_BUBBLE_CLOSE_REASON_H_

« no previous file with comments | « chrome/browser/ui/chrome_bubble_manager.cc ('k') | components/bubble/bubble_delegate.h » ('j') | components/bubble/bubble_delegate.h » ('J')