chrome/browser/ui/chrome_bubble_manager.h - Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/chrome_bubble_manager.h

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/chrome_bubble_manager.h

diff --git a/chrome/browser/ui/chrome_bubble_manager.h b/chrome/browser/ui/chrome_bubble_manager.h

index 1a517cdec00901ce8d420c3d0cbea5a0a32329e4..b5cbc00c5d6a8e52e9f015cb61113d302d0b4e2c 100644

--- a/chrome/browser/ui/chrome_bubble_manager.h

+++ b/chrome/browser/ui/chrome_bubble_manager.h

@@ -28,6 +28,7 @@ class ChromeBubbleManager : public BubbleManager,

int reason) override;

// content::WebContentsObserver:

+ void FrameDeleted(content::RenderFrameHost* render_frame_host) override;

void DidToggleFullscreenModeForTab(bool entered_fullscreen) override;

void NavigationEntryCommitted(

const content::LoadCommittedDetails& load_details) override;

« no previous file with comments | « no previous file | chrome/browser/ui/chrome_bubble_manager.cc » ('j') | components/bubble/bubble_close_reason.h » ('J')