| Index: chrome/browser/ui/chrome_bubble_manager.cc
|
| diff --git a/chrome/browser/ui/chrome_bubble_manager.cc b/chrome/browser/ui/chrome_bubble_manager.cc
|
| index 56b686e10ca1619044bdd2c77c79b9b5bf4a104c..9b0deb7951c735b7a0917937172736824bfd92f2 100644
|
| --- a/chrome/browser/ui/chrome_bubble_manager.cc
|
| +++ b/chrome/browser/ui/chrome_bubble_manager.cc
|
| @@ -97,6 +97,9 @@ static void LogBubbleCloseReason(BubbleReference bubble,
|
| case BUBBLE_CLOSE_CANCELED:
|
| UMA_HISTOGRAM_SPARSE_SLOWLY("Bubbles.Close.Canceled", bubble_id);
|
| return;
|
| + case BUBBLE_CLOSE_FRAME_DESTROYED:
|
| + UMA_HISTOGRAM_SPARSE_SLOWLY("Bubbles.Close.FrameDestroyed", bubble_id);
|
| + return;
|
| }
|
|
|
| NOTREACHED();
|
| @@ -139,6 +142,14 @@ void ChromeBubbleManager::ActiveTabChanged(content::WebContents* old_contents,
|
| Observe(new_contents);
|
| }
|
|
|
| +void ChromeBubbleManager::FrameDeleted(
|
| + content::RenderFrameHost* render_frame_host) {
|
| + // When a frame is destroyed, bubbles spawned by that frame should default to
|
| + // being closed, so that they can't traverse any references they hold to the
|
| + // destroyed frame.
|
| + CloseAllBubbles(BUBBLE_CLOSE_FRAME_DESTROYED);
|
| +}
|
| +
|
| void ChromeBubbleManager::DidToggleFullscreenModeForTab(
|
| bool entered_fullscreen) {
|
| CloseAllBubbles(BUBBLE_CLOSE_FULLSCREEN_TOGGLED);
|
|
|