Issue 1572043002: dart2js cps: Do not remove unused refinements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1572043002: dart2js cps: Do not remove unused refinements. (Closed)

Created:
4 years, 11 months ago by asgerf

Modified:
4 years, 11 months ago

Reviewers:
Siggi Cherem (dart-lang), Kevin Millikin (Google), sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Do not remove unused refinements. Unused refinements may become used after GVN. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/e3a9b74b569150e15996fbdeffe01b5e46609f03

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart	View		3 chunks	+5 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

asgerf

4 years, 11 months ago (2016-01-11 17:13:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e3a9b74b569150e15996fbdeffe01b5e46609f03 (presubmit successful).