Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

Issue 1572043002: dart2js cps: Do not remove unused refinements. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart
diff --git a/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart b/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart
index f7365b44e731ae5b3ff18cb30d9681d887f5e78d..0e93623c5fb2ed92aec0b1e231ebeed56e4d7aa1 100644
--- a/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart
+++ b/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart
@@ -6,6 +6,7 @@ library dart2js.cps_ir.shrinking_reductions;
import 'cps_ir_nodes.dart';
import 'optimizers.dart';
+import 'cps_fragment.dart';
/**
* [ShrinkingReducer] applies shrinking reductions to CPS terms as described
@@ -91,7 +92,8 @@ class ShrinkingReducer extends Pass {
assert(_isDeadVal(task.node));
// Remove dead primitive.
- LetPrim letPrim = task.node;;
+ LetPrim letPrim = task.node;
+ destroyRefinementsOfDeadPrimitive(letPrim.primitive);
_removeNode(letPrim);
// Perform bookkeeping on removed body and scan for new redexes.
@@ -242,7 +244,8 @@ class ShrinkingReducer extends Pass {
/// Returns true iff the bound primitive is unused, and has no effects
/// preventing it from being eliminated.
bool _isDeadVal(LetPrim node) {
- return node.primitive.hasNoUses && node.primitive.isSafeForElimination;
+ return node.primitive.hasNoEffectiveUses &&
+ node.primitive.isSafeForElimination;
}
/// Returns true iff the continuation is unused.
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698