pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart - Issue 1572043002: dart2js cps: Do not remove unused refinements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

Issue 1572043002: dart2js cps: Do not remove unused refinements. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

index 659b5e2f288f75b6f4e2d8ef46b682d026efa13b..976c7ece75ea52579b4400749d980b465d367ad9 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

@@ -732,7 +732,7 @@ class Refinement extends Primitive {

: value = new Reference<Primitive>(value);

bool get hasValue => true;

- bool get isSafeForElimination => true;

+ bool get isSafeForElimination => false;

bool get isSafeForReordering => false;

accept(Visitor visitor) => visitor.visitRefinement(this);

« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart » ('j') | no next file with comments »