Pass Manifest JSON paser error line and column number to console.

Pass Manifest JSON paser error line and column number to console.

BUG=540493
Committed: https://crrev.com/33d6a198ce117c541a8568405870c2b5db7ad54c
Cr-Commit-Position: refs/heads/master@{#369371}

[horo, 2016-01-08 05:45:23]

Description was changed from

==========
Pass Manifest JSON paser error line and column number to console.

BUG=540493
==========

to

==========
Pass Manifest JSON paser error line and column number to console.

This CL depends on https://codereview.chromium.org/1564913003/.

BUG=540493
==========

[horo, 2016-01-08 10:51:06]

Patchset #1 (id:1) has been deleted

[horo, 2016-01-08 12:31:52]

horo@chromium.org changed reviewers:
+ pfeldman@chromium.org

[horo, 2016-01-08 12:31:52]

pfeldman@
Could you please review this?

[horo, 2016-01-12 03:26:35]

Description was changed from

==========
Pass Manifest JSON paser error line and column number to console.

This CL depends on https://codereview.chromium.org/1564913003/.

BUG=540493
==========

to

==========
Pass Manifest JSON paser error line and column number to console.

BUG=540493
==========

[pfeldman, 2016-01-13 00:14:24]

lgtm

[horo, 2016-01-13 02:03:04]

horo@chromium.org changed reviewers:
+ thakis@chromium.org

[horo, 2016-01-13 02:03:05]

thakis@
Could you please review base/json/*?

Thank you.

[Nico, 2016-01-13 20:50:43]

base/ lgtm, but:

(doesn't have to be in this cl, and optional too)

https://codereview.chromium.org/1571633002/diff/20001/base/json/json_parser.h
File base/json/json_parser.h (right):

https://codereview.chromium.org/1571633002/diff/20001/base/json/json_parser.h...
base/json/json_parser.h:61: int error_line() const;
Add a comment that explains when these return valid values, and what they return
when this is called at the wrong time

https://codereview.chromium.org/1571633002/diff/20001/base/json/json_parser.h...
base/json/json_parser.h:62: int error_column() const;
There's so much error data here now -- does it make sense to have Parse return
some Result object, or should there be some JSonError struct?

https://codereview.chromium.org/1571633002/diff/20001/base/json/json_reader.h
File base/json/json_reader.h (right):

https://codereview.chromium.org/1571633002/diff/20001/base/json/json_reader.h...
base/json/json_reader.h:112: int* error_column_out = nullptr);
That'd also help here...

[horo, 2016-01-14 02:25:45]

https://codereview.chromium.org/1571633002/diff/20001/base/json/json_parser.h
File base/json/json_parser.h (right):

https://codereview.chromium.org/1571633002/diff/20001/base/json/json_parser.h...
base/json/json_parser.h:61: int error_line() const;
On 2016/01/13 20:50:39, Nico wrote:
> Add a comment that explains when these return valid values, and what they
return
> when this is called at the wrong time

Done.

https://codereview.chromium.org/1571633002/diff/20001/base/json/json_parser.h...
base/json/json_parser.h:62: int error_column() const;
On 2016/01/13 20:50:39, Nico wrote:
> There's so much error data here now -- does it make sense to have Parse return
> some Result object, or should there be some JSonError struct?

That sound good.
I will create another CL.

[horo, 2016-01-14 02:25:55]

The CQ bit was checked by horo@chromium.org

[horo, 2016-01-14 02:25:56]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1571633002/#ps40001
(title: "add comments")

[commit-bot: I haz the power, 2016-01-14 02:28:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571633002/40001

[commit-bot: I haz the power, 2016-01-14 04:39:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 04:39:26]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)

[horo, 2016-01-14 08:35:28]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2016-01-14 08:35:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571633002/40001

[commit-bot: I haz the power, 2016-01-14 08:41:51]

Description was changed from

==========
Pass Manifest JSON paser error line and column number to console.

BUG=540493
==========

to

==========
Pass Manifest JSON paser error line and column number to console.

BUG=540493
==========

[commit-bot: I haz the power, 2016-01-14 08:41:52]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-01-14 08:43:58]

Description was changed from

==========
Pass Manifest JSON paser error line and column number to console.

BUG=540493
==========

to

==========
Pass Manifest JSON paser error line and column number to console.

BUG=540493

Committed: https://crrev.com/33d6a198ce117c541a8568405870c2b5db7ad54c
Cr-Commit-Position: refs/heads/master@{#369371}
==========

[commit-bot: I haz the power, 2016-01-14 08:43:58]

Patchset 2 (id:??) landed as
https://crrev.com/33d6a198ce117c541a8568405870c2b5db7ad54c
Cr-Commit-Position: refs/heads/master@{#369371}