Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2392)

Unified Diff: content/renderer/manifest/manifest_parser_unittest.cc

Issue 1571633002: Pass Manifest JSON paser error line and column number to console. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/manifest/manifest_parser.cc ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/manifest/manifest_parser_unittest.cc
diff --git a/content/renderer/manifest/manifest_parser_unittest.cc b/content/renderer/manifest/manifest_parser_unittest.cc
index f98691c023ce4713fdd423e38e35533ee2268832..cc5d1feaa2848361d9cb8a2bc048d0e67ac44624 100644
--- a/content/renderer/manifest/manifest_parser_unittest.cc
+++ b/content/renderer/manifest/manifest_parser_unittest.cc
@@ -31,7 +31,11 @@ class ManifestParserTest : public testing::Test {
const GURL& manifest_url) {
ManifestParser parser(data, document_url, manifest_url);
parser.Parse();
- errors_ = parser.errors();
+ errors_.clear();
+ for (const scoped_ptr<ManifestParser::ErrorInfo>& error_info :
+ parser.errors()) {
+ errors_.push_back(error_info->error_msg);
+ }
return parser.manifest();
}
« no previous file with comments | « content/renderer/manifest/manifest_parser.cc ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698