base/json/json_reader.h - Issue 1571633002: Pass Manifest JSON paser error line and column number to console.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_reader.h

Issue 1571633002: Pass Manifest JSON paser error line and column number to console. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/json/json_reader.h

diff --git a/base/json/json_reader.h b/base/json/json_reader.h

index 45783b0cf81004f9f6796b8ba9d8438cdef19d9d..c6bcb528e3b1ad0cd44a6b8559065fe56db367f3 100644

--- a/base/json/json_reader.h

+++ b/base/json/json_reader.h

@@ -107,7 +107,9 @@ class BASE_EXPORT JSONReader {

static scoped_ptr<Value> ReadAndReturnError(const StringPiece& json,

int options, // JSONParserOptions

int* error_code_out,

- std::string* error_msg_out);

+ std::string* error_msg_out,

+ int* error_line_out = nullptr,

+ int* error_column_out = nullptr);

// Converts a JSON parse error code into a human readable message.

// Returns an empty string if error_code is JSON_NO_ERROR.

« no previous file with comments | « base/json/json_parser.cc ('k') | base/json/json_reader.cc » ('j') | no next file with comments »