Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1570873005: Tidy up shading patterns (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Bounds. #

Total comments: 1

Patch Set 3 : || #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -80 lines) Patch
M core/include/fpdfapi/fpdf_resource.h View 1 2 2 chunks +18 lines, -24 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp View 1 3 chunks +26 lines, -44 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +7 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, for review. https://codereview.chromium.org/1570873005/diff/1/core/include/fpdfapi/fpdf_resource.h File core/include/fpdfapi/fpdf_resource.h (left): https://codereview.chromium.org/1570873005/diff/1/core/include/fpdfapi/fpdf_resource.h#oldcode715 core/include/fpdfapi/fpdf_resource.h:715: FX_BOOL Reload(); NB: Reload() unused.
4 years, 11 months ago (2016-01-09 00:56:28 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1570873005/diff/20001/core/include/fpdfapi/fpdf_resource.h File core/include/fpdfapi/fpdf_resource.h (right): https://codereview.chromium.org/1570873005/diff/20001/core/include/fpdfapi/fpdf_resource.h#newcode717 core/include/fpdfapi/fpdf_resource.h:717: // Still keep m_pCS as some CPDF_ColorSpace (name ...
4 years, 11 months ago (2016-01-09 01:03:56 UTC) #3
Tom Sepez
4 years, 11 months ago (2016-01-11 16:47:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
a07804a3b16c10fa2011ef56d1dacefb7d21e4f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698