Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1569873003: Revert of SkTreatAsSprite should take AA into account (Closed)

Created:
4 years, 11 months ago by reed1
Modified:
4 years, 11 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org, vmpstr
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkTreatAsSprite should take AA into account (patchset #5 id:80001 of https://codereview.chromium.org/1566943002/ ) Reason for revert: Need to use SkLeftShift since the arg could be negative Original issue's description: > SkTreatAsSprite should take AA into account > > Currently we always call SkTreatAsSprite with 0 subpixel bits, which means > subpixel translations are ignored. This is incorrect for the anti-aliased > case (drawSprite always pixel-snaps, so we lose edge AA). > > The CL updates SkTreatAsSprite to take an SkPaint argument and use 8 subpixel > bits when AA is requested. > > Also remove unused SkTreatAsSpriteFilter. > > BUG=skia:4761 > R=reed@google.com > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1566943002 > > Committed: https://skia.googlesource.com/skia/+/983dc2541a729609037a05eba731b3eb9788c517 TBR=fmalita@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4761 Committed: https://skia.googlesource.com/skia/+/5423ee17ed5a1becd0aeaa89d8faaaa5e2696cbb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -38 lines) Patch
M src/core/SkCanvas.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkDraw.cpp View 2 chunks +11 lines, -3 lines 0 comments Download
M src/core/SkMatrix.cpp View 2 chunks +3 lines, -9 lines 0 comments Download
M src/core/SkMatrixUtils.h View 1 chunk +24 lines, -7 lines 0 comments Download
M tests/DrawBitmapRectTest.cpp View 3 chunks +20 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of SkTreatAsSprite should take AA into account
4 years, 11 months ago (2016-01-07 17:15:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569873003/1
4 years, 11 months ago (2016-01-07 17:15:14 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 17:15:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5423ee17ed5a1becd0aeaa89d8faaaa5e2696cbb

Powered by Google App Engine
This is Rietveld 408576698