Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1569543002: Revert of Apply the Surface Texture transformation matrix during texture copy. (Closed)

Created:
4 years, 11 months ago by Łukasz Anforowicz
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Apply the Surface Texture transformation matrix during texture copy. (patchset #7 id:140001 of https://codereview.chromium.org/1536713002/ ) Reason for revert: The CL was/is the main suspect for causing crbug.com/574811. Original issue's description: > Apply the Surface Texture transformation matrix during texture copy. > > Android Surface Textures have an associated UV transform matrix that can > potentially vary from frame to frame. If the texture is copied, it is > useful for the copy to have a consistent orientation, rather than having > to propagate the UV transformation matrix with the copy as well. > > Because the Surface Texture is meant to be used with (0,0) meaning > the bottom left of the texture, the result of this operation from the > perspective of Chromium is a y-flipped texture. > > BUG=226218 > > Committed: https://crrev.com/907d1b74f2f3b50d77577c8d83c0cd2472400b3f > Cr-Commit-Position: refs/heads/master@{#367714} TBR=reveman@chromium.org,sievers@chromium.org,kbr@chromium.org,ccameron@chromium.org,tobiasjs@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=226218 Committed: https://crrev.com/e4576126e027613613449303c5d50dcd5d4bbac9 Cr-Commit-Position: refs/heads/master@{#367844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -193 lines) Patch
M content/common/gpu/stream_texture_android.h View 3 chunks +0 lines, -15 lines 0 comments Download
M content/common/gpu/stream_texture_android.cc View 8 chunks +49 lines, -178 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Łukasz Anforowicz
Created Revert of Apply the Surface Texture transformation matrix during texture copy.
4 years, 11 months ago (2016-01-06 17:10:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569543002/1
4 years, 11 months ago (2016-01-06 17:11:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 17:12:23 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 17:13:31 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4576126e027613613449303c5d50dcd5d4bbac9
Cr-Commit-Position: refs/heads/master@{#367844}

Powered by Google App Engine
This is Rietveld 408576698