Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 1568353002: Don't test directly against Scanner::kNoSourcePos instead use >= 0. (Closed)

Created:
4 years, 11 months ago by Cutch
Modified:
4 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't test directly against Scanner::kNoSourcePos instead use >= 0. A follow up CL will introduce new sentinel token positions that are < Scanner::kNoSourcePos (-1) Gazoo R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/789ed02b39970136da741fd8e7326a30654cb6a0

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M runtime/vm/debugger.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
Cutch
4 years, 11 months ago (2016-01-08 17:38:15 UTC) #3
rmacnak
lgtm Note in commit message this is prep for additional synthetic token positions.
4 years, 11 months ago (2016-01-08 20:18:37 UTC) #4
Cutch
4 years, 11 months ago (2016-01-08 20:20:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
789ed02b39970136da741fd8e7326a30654cb6a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698