Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 1568353002: Don't test directly against Scanner::kNoSourcePos instead use >= 0. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1402 matching lines...) Expand 10 before | Expand all | Expand 10 after
1413 __ sw(reg, Address(SP, 1 * kWordSize)); 1413 __ sw(reg, Address(SP, 1 * kWordSize));
1414 __ LoadObject(TMP, obj); 1414 __ LoadObject(TMP, obj);
1415 __ sw(TMP, Address(SP, 0 * kWordSize)); 1415 __ sw(TMP, Address(SP, 0 * kWordSize));
1416 if (is_optimizing()) { 1416 if (is_optimizing()) {
1417 __ BranchLinkPatchable( 1417 __ BranchLinkPatchable(
1418 *StubCode::OptimizedIdenticalWithNumberCheck_entry()); 1418 *StubCode::OptimizedIdenticalWithNumberCheck_entry());
1419 } else { 1419 } else {
1420 __ BranchLinkPatchable( 1420 __ BranchLinkPatchable(
1421 *StubCode::UnoptimizedIdenticalWithNumberCheck_entry()); 1421 *StubCode::UnoptimizedIdenticalWithNumberCheck_entry());
1422 } 1422 }
1423 if (token_pos != Scanner::kNoSourcePos) { 1423 if (token_pos >= 0) {
1424 AddCurrentDescriptor(RawPcDescriptors::kRuntimeCall, 1424 AddCurrentDescriptor(RawPcDescriptors::kRuntimeCall,
1425 Thread::kNoDeoptId, 1425 Thread::kNoDeoptId,
1426 token_pos); 1426 token_pos);
1427 } 1427 }
1428 __ Comment("EqualityRegConstCompare return"); 1428 __ Comment("EqualityRegConstCompare return");
1429 // Stub returns result in CMPRES1 (if it is 0, then reg and obj are equal). 1429 // Stub returns result in CMPRES1 (if it is 0, then reg and obj are equal).
1430 __ lw(reg, Address(SP, 1 * kWordSize)); // Restore 'reg'. 1430 __ lw(reg, Address(SP, 1 * kWordSize)); // Restore 'reg'.
1431 __ addiu(SP, SP, Immediate(2 * kWordSize)); // Discard constant. 1431 __ addiu(SP, SP, Immediate(2 * kWordSize)); // Discard constant.
1432 return Condition(CMPRES1, ZR, EQ); 1432 return Condition(CMPRES1, ZR, EQ);
1433 } else { 1433 } else {
(...skipping 13 matching lines...) Expand all
1447 __ addiu(SP, SP, Immediate(-2 * kWordSize)); 1447 __ addiu(SP, SP, Immediate(-2 * kWordSize));
1448 __ sw(left, Address(SP, 1 * kWordSize)); 1448 __ sw(left, Address(SP, 1 * kWordSize));
1449 __ sw(right, Address(SP, 0 * kWordSize)); 1449 __ sw(right, Address(SP, 0 * kWordSize));
1450 if (is_optimizing()) { 1450 if (is_optimizing()) {
1451 __ BranchLinkPatchable( 1451 __ BranchLinkPatchable(
1452 *StubCode::OptimizedIdenticalWithNumberCheck_entry()); 1452 *StubCode::OptimizedIdenticalWithNumberCheck_entry());
1453 } else { 1453 } else {
1454 __ BranchLinkPatchable( 1454 __ BranchLinkPatchable(
1455 *StubCode::UnoptimizedIdenticalWithNumberCheck_entry()); 1455 *StubCode::UnoptimizedIdenticalWithNumberCheck_entry());
1456 } 1456 }
1457 if (token_pos != Scanner::kNoSourcePos) { 1457 if (token_pos >= 0) {
1458 AddCurrentDescriptor(RawPcDescriptors::kRuntimeCall, 1458 AddCurrentDescriptor(RawPcDescriptors::kRuntimeCall,
1459 Thread::kNoDeoptId, 1459 Thread::kNoDeoptId,
1460 token_pos); 1460 token_pos);
1461 } 1461 }
1462 __ Comment("EqualityRegRegCompare return"); 1462 __ Comment("EqualityRegRegCompare return");
1463 // Stub returns result in CMPRES1 (if it is 0, then left and right are 1463 // Stub returns result in CMPRES1 (if it is 0, then left and right are
1464 // equal). 1464 // equal).
1465 __ lw(right, Address(SP, 0 * kWordSize)); 1465 __ lw(right, Address(SP, 0 * kWordSize));
1466 __ lw(left, Address(SP, 1 * kWordSize)); 1466 __ lw(left, Address(SP, 1 * kWordSize));
1467 __ addiu(SP, SP, Immediate(2 * kWordSize)); 1467 __ addiu(SP, SP, Immediate(2 * kWordSize));
(...skipping 429 matching lines...) Expand 10 before | Expand all | Expand 10 after
1897 __ AddImmediate(SP, kDoubleSize); 1897 __ AddImmediate(SP, kDoubleSize);
1898 } 1898 }
1899 1899
1900 1900
1901 #undef __ 1901 #undef __
1902 1902
1903 1903
1904 } // namespace dart 1904 } // namespace dart
1905 1905
1906 #endif // defined TARGET_ARCH_MIPS 1906 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698