runtime/vm/flow_graph_compiler.cc - Issue 1568353002: Don't test directly against Scanner::kNoSourcePos instead use >= 0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 1568353002: Don't test directly against Scanner::kNoSourcePos instead use >= 0. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler.cc

diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc

index ddd5dec6d3c26afd2a905dac2d22ba700433aeba..5197713860f2fa4068f7a2b346429a037ffa9998 100644

--- a/runtime/vm/flow_graph_compiler.cc

+++ b/runtime/vm/flow_graph_compiler.cc

@@ -444,7 +444,7 @@ void FlowGraphCompiler::EmitInstructionPrologue(Instruction* instr) {

void FlowGraphCompiler::EmitSourceLine(Instruction* instr) {

- if ((instr->token_pos() == Scanner::kNoSourcePos) || (instr->env() == NULL)) {

+ if ((instr->token_pos() < 0) || (instr->env() == NULL)) {

return;

}

const Script& script =

« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »