content/renderer/shared_worker/embedded_shared_worker_stub.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/shared_worker/embedded_shared_worker_stub.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/shared_worker/embedded_shared_worker_stub.cc

diff --git a/content/renderer/shared_worker/embedded_shared_worker_stub.cc b/content/renderer/shared_worker/embedded_shared_worker_stub.cc

index 39b0d3526e3e727e9220a30e8eff9347dd6c926d..94529350a0fc6edd047366624c46d1ed44fb01a5 100644

--- a/content/renderer/shared_worker/embedded_shared_worker_stub.cc

+++ b/content/renderer/shared_worker/embedded_shared_worker_stub.cc

@@ -229,7 +229,7 @@ blink::WebWorkerContentSettingsClientProxy*

EmbeddedSharedWorkerStub::createWorkerContentSettingsClientProxy(

const blink::WebSecurityOrigin& origin) {

return new EmbeddedSharedWorkerContentSettingsClientProxy(

- GURL(origin.toString()),

+ GURL(base::string16(origin.toString())),

origin.isUnique(),

route_id_,

ChildThreadImpl::current()->thread_safe_sender());