Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 7b0bd8964d5991fba14fa62fb519de9e7a3afbaf..7bb9e5dec231f8a9444f6392493ac9fd2c2d0a20 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -31,6 +31,7 @@
#include "content/common/mojo/service_registry_impl.h"
#include "content/common/service_worker/embedded_worker_messages.h"
#include "content/common/service_worker/service_worker_messages.h"
+#include "content/public/child/url_conversion.h"
#include "content/public/common/referrer.h"
#include "content/public/renderer/content_renderer_client.h"
#include "content/public/renderer/document_state.h"
@@ -447,10 +448,8 @@ void ServiceWorkerContextClient::reportException(
int column_number,
const blink::WebString& source_url) {
Send(new EmbeddedWorkerHostMsg_ReportException(
- embedded_worker_id_,
- error_message,
- line_number,
- column_number, GURL(source_url)));
+ embedded_worker_id_, error_message, line_number, column_number,
+ WebStringToGURL(source_url)));
}
void ServiceWorkerContextClient::reportConsoleMessage(
@@ -464,7 +463,7 @@ void ServiceWorkerContextClient::reportConsoleMessage(
params.message_level = level;
params.message = message;
params.line_number = line_number;
- params.source_url = GURL(source_url);
+ params.source_url = WebStringToGURL(source_url);
Send(new EmbeddedWorkerHostMsg_ReportConsoleMessage(
embedded_worker_id_, params));

Powered by Google App Engine
This is Rietveld 408576698