Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: content/public/child/url_conversion.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/child/url_conversion.cc
diff --git a/content/public/child/url_conversion.cc b/content/public/child/url_conversion.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e10d806bbe6f9b1f742e0379e076891bdcd978a1
--- /dev/null
+++ b/content/public/child/url_conversion.cc
@@ -0,0 +1,23 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/strings/string_piece.h"
+#include "third_party/WebKit/public/platform/WebString.h"
+#include "url/gurl.h"
+
+namespace content {
+
+GURL WebStringToGURL(const blink::WebString& web_string) {
+ if (web_string.is8Bit()) {
+ return GURL(base::StringPiece(
+ reinterpret_cast<const char*>(web_string.data8OrNull()),
esprehn 2016/01/08 02:12:50 I'm not sure if this is right, the 8 bit data is n
+ web_string.length()));
+ } else {
+ return GURL(base::StringPiece16(
+ static_cast<const base::char16*>(web_string.data16OrNull()),
+ web_string.length()));
+ }
+}
+
+} // namespace content

Powered by Google App Engine
This is Rietveld 408576698