mandoline/ui/desktop_ui/browser_window.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mandoline/ui/desktop_ui/browser_window.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mandoline/ui/desktop_ui/browser_window.cc

diff --git a/mandoline/ui/desktop_ui/browser_window.cc b/mandoline/ui/desktop_ui/browser_window.cc

index ba3d24c4e15fa29d68d57c8130bb473b8b1745a5..eba87b612d42a053038f71e18b2b8bed3c5e724c 100644

--- a/mandoline/ui/desktop_ui/browser_window.cc

+++ b/mandoline/ui/desktop_ui/browser_window.cc

@@ -303,7 +303,7 @@ void BrowserWindow::TopLevelNavigateRequest(mojo::URLRequestPtr request) {

}

void BrowserWindow::TopLevelNavigationStarted(const mojo::String& url) {

- GURL gurl(url);

+ GURL gurl(url.get());

bool changed = current_url_ != gurl;

current_url_ = gurl;

if (changed)