mandoline/ui/desktop_ui/browser_manager.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mandoline/ui/desktop_ui/browser_manager.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mandoline/ui/desktop_ui/browser_manager.cc

diff --git a/mandoline/ui/desktop_ui/browser_manager.cc b/mandoline/ui/desktop_ui/browser_manager.cc

index b36f428da2637c50fd1912ec545c45cf8b1da19c..cb54be136605c2c239818d0eb3ee2fe343e837ea 100644

--- a/mandoline/ui/desktop_ui/browser_manager.cc

+++ b/mandoline/ui/desktop_ui/browser_manager.cc

@@ -46,7 +46,7 @@ void BrowserManager::LaunchURL(const mojo::String& url) {

DCHECK(!browsers_.empty());

// TODO(fsamuel): Create a new Browser once we support multiple browser

// windows.

- (*browsers_.begin())->LoadURL(GURL(url));

+ (*browsers_.begin())->LoadURL(GURL(url.get()));

}

void BrowserManager::Initialize(mojo::ApplicationImpl* app) {