media/blink/encrypted_media_player_support.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/encrypted_media_player_support.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/blink/encrypted_media_player_support.cc

diff --git a/media/blink/encrypted_media_player_support.cc b/media/blink/encrypted_media_player_support.cc

index 9e9a0399b6d33260134c11d49f6623f40534937d..b192f4910562ec00ccf39b62dbe979aa62979f50 100644

--- a/media/blink/encrypted_media_player_support.cc

+++ b/media/blink/encrypted_media_player_support.cc

@@ -16,6 +16,7 @@

#include "media/base/bind_to_current_loop.h"

#include "media/base/key_systems.h"

#include "media/blink/webcontentdecryptionmodule_impl.h"

+#include "third_party/WebKit/public/platform/URLConversion.h"

#include "third_party/WebKit/public/platform/WebContentDecryptionModule.h"

#include "third_party/WebKit/public/platform/WebMediaPlayerEncryptedMediaClient.h"

#include "third_party/WebKit/public/web/WebDocument.h"

@@ -171,7 +172,8 @@ EncryptedMediaPlayerSupport::GenerateKeyRequestInternal(

BIND_TO_RENDER_LOOP(&EncryptedMediaPlayerSupport::OnKeyError),

BIND_TO_RENDER_LOOP(&EncryptedMediaPlayerSupport::OnKeyMessage)));

- GURL security_origin(frame->document().securityOrigin().toString());

+ GURL security_origin(

+ blink::WebStringToGURL(frame->document().securityOrigin().toString()));

proxy_decryptor_->CreateCdm(cdm_factory_, key_system, security_origin,

cdm_context_ready_cb_);

current_key_system_ = key_system;

« no previous file with comments | « mandoline/ui/desktop_ui/browser_window.cc ('k') | media/blink/key_system_config_selector.cc » ('j') | no next file with comments »