mojo/shell/shell_application_delegate.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/shell_application_delegate.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/shell/shell_application_delegate.cc

diff --git a/mojo/shell/shell_application_delegate.cc b/mojo/shell/shell_application_delegate.cc

index 650740d11b8b66b8963ee9c10ac783eb812e7071..86df31d0d61572cd05a23f743bdd133db37daf4d 100644

--- a/mojo/shell/shell_application_delegate.cc

+++ b/mojo/shell/shell_application_delegate.cc

@@ -39,7 +39,7 @@ void ShellApplicationDelegate::CreateInstanceForHandle(

const String& url,

CapabilityFilterPtr filter,

InterfaceRequest<mojom::PIDReceiver> pid_receiver) {

- manager_->CreateInstanceForHandle(std::move(channel), GURL(url),

+ manager_->CreateInstanceForHandle(std::move(channel), GURL(url.get()),

std::move(filter), std::move(pid_receiver));

}